nodejs 12 support #1151
Description
Nodejs 12 was released on Tuesday, and sqlite3 fails to build for it. Here are the notable errors:
In file included from ../../nan/nan_new.h:189,
from ../../nan/nan.h:203,
from ../src/database.h:10,
from ../src/database.cc:4:
../../nan/nan_implementation_12_inl.h:337:58: error: expected primary-expression before ‘>’ token
return v8::StringObject::New(value).As<v8::StringObject>();
^
../../nan/nan_implementation_12_inl.h:337:60: error: expected primary-expression before ‘)’ token
return v8::StringObject::New(value).As<v8::StringObject>();
^
In file included from ../src/database.h:10,
from ../src/database.cc:4:
../../nan/nan.h: In constructor ‘Nan::Utf8String::Utf8String(v8::Local<v8::Value>)’:
../../nan/nan.h:1034:53: error: no matching function for call to ‘v8::Value::ToString()’
v8::Local<v8::String> string = from->ToString();
^
In file included from ../src/database.h:10,
from ../src/database.cc:4:
../../nan/nan.h:1044:74: error: no matching function for call to ‘v8::String::WriteUtf8(char*&, int, int, const int&)’
length_ = string->WriteUtf8(str_, static_cast<int>(len), 0, flags);
^
The above three seem to be nan's fault, their ticket tracking node 12 support is nodejs/nan#849 . The below however seem to be sqlite3's fault:
../src/database.cc: In static member function ‘static Nan::NAN_METHOD_RETURN_TYPE node_sqlite3::Database::Configure(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/database.cc:351:9: error: no matching function for call to ‘v8::String::Concat(v8::Local<v8::String>, v8::Local<v8::String>)’
)));
^
../src/database.cc:351:11: error: return-statement with a value, in function returning ‘Nan::NAN_METHOD_RETURN_TYPE’ {aka ‘void’} [-fpermissive]
)));
^
In file included from ../src/database.cc:3:
../src/database.cc: In static member function ‘static void node_sqlite3::Database::Work_AfterExec(uv_work_t*)’:
../src/macros.h:91:13: error: no matching function for call to ‘v8::String::Concat(v8::Local<v8::String>, v8::Local<v8::String>)’
), \
^