Test fix - specify electron-mocha version. #1145
Conversation
bruce-one
force-pushed
the
electron-mocha
branch
from
01b1a1c to
a0964e2
Compare
|
This seems to fix a lot of tests, but Node 11 on OSX seems to be failing with a segfault? |
|
(Actually, that failure kinda looks to be a gremlin? It failed in 10 once, then failed in 11. Will kick it off again.) |
|
On the whole this looks to help a lot, but the sporadic failures do seem to be consistently in the Backup api tests on OSX... eg: All these failures state there's a segfault around the Not sure if that means there's some not ideal code in that area? I'm running the test suite in a while loop, but no failure yet... I don't have access to any OSX machines to test on unfortunately. |
|
Thank you @bruce-one! I've spotted the segmentation fault as well, I'll ping @paulfitz as he's the author of the backup API. |
|
Hmmm, oddly enough it sometimes also returns a different error. Not only the segmentation fault error but instead: cfr: https://travis-ci.org/mapbox/node-sqlite3/jobs/521197134#L3926 To the best of my knowledge, this occurs in the test |
|
Merging, as the CI errors are unrelated to this PR. |
electron-mocha dropped support for node 6 in their 8.0.0 release - https://github.com/jprichardson/electron-mocha/blob/master/CHANGELOG.md
(Just triggering the CI for now, apologies for any noise.)