Skip to content

Node 12 workaround in Appveyor #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kewde merged 10 commits into from
May 7, 2019
Merged

Node 12 workaround in Appveyor #1158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5684e01
Node version 12 workaround in Appveyor.
bruce-one May 2, 2019
4250f0a
Node 12 in Travis.
bruce-one May 2, 2019
616fc0f
Remove unused code for now.
bruce-one May 2, 2019
ed6501f
Trying to fix Travis build bug.
bruce-one May 2, 2019
8395c0b
Trying to find the right spot...
bruce-one May 2, 2019
c0bac02
Another try.
bruce-one May 2, 2019
7dcd6aa
Try building from source due to GLIBC version.
bruce-one May 2, 2019
919d7a8
Use newer Ubuntu for node 12 for glibc.
bruce-one May 2, 2019
f62b415
Build.
bruce-one May 3, 2019
43df8a0
Cleanup.
bruce-one May 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,14 @@ addons:
matrix:
include:
# Linux
- os: linux
dist: xenial
compiler: clang
env: NODE_VERSION="12"
addons:
apt:
sources: [ 'ubuntu-toolchain-r-test','llvm-toolchain-precise-3.5', 'gcc-multilib', 'g++-multilib', 'libsqlite3-dev:i386' ]
packages: [ 'clang-3.5', 'libstdc++-4.9-dev']
- os: linux
compiler: clang
env: NODE_VERSION="11"
Expand Down Expand Up @@ -83,6 +91,9 @@ matrix:
sources: [ 'ubuntu-toolchain-r-test','llvm-toolchain-precise-3.5', 'gcc-multilib', 'g++-multilib', 'libsqlite3-dev:i386' ]
packages: [ 'clang-3.5','libsqlite3-dev']
# OS X
- os: osx
compiler: clang
env: NODE_VERSION="12" # node abi 67
- os: osx
compiler: clang
env: NODE_VERSION="11" # node abi 67
Expand Down
4 changes: 4 additions & 0 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ environment:
platform: x64
- nodejs_version: 11
platform: x86
- nodejs_version: 12
platform: x64
- nodejs_version: 12
platform: x86
# electron
- nodejs_version: 10
platform: x64
Expand Down
3 changes: 1 addition & 2 deletions scripts/build-appveyor.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ ECHO using MSBuild^: && CALL msbuild /version && ECHO.
IF %ERRORLEVEL% NEQ 0 GOTO ERROR

ECHO downloading/installing node
IF /I "%platform%"=="x64" powershell Install-Product node $env:nodejs_version x64
IF /I "%platform%"=="x86" powershell Install-Product node $env:nodejs_version x86
powershell Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version) $env:PLATFORM
IF %ERRORLEVEL% NEQ 0 GOTO ERROR

powershell Set-ExecutionPolicy Unrestricted -Scope CurrentUser -Force
Expand Down
4 changes: 2 additions & 2 deletions scripts/install_node.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ nvm unload || true
rm -rf ./__nvm/ && git clone --depth 1 https://github.com/creationix/nvm.git ./__nvm
source ./__nvm/nvm.sh
nvm install ${NODE_VERSION}
nvm use ${NODE_VERSION}
nvm use --delete-prefix ${NODE_VERSION}
node --version
npm --version
which node
which node