-
-
Notifications
You must be signed in to change notification settings - Fork 830
update node-pre-gyp version to ^0.14.0 #1265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
please review this pull request |
The problem is: kewde, the maintainer, tried upgrading to that version only to have it break something. He never documented what happened but did close the PR he tried setting up. I don’t know enough about how all of this works yet to be able to know what the issue was but do know it’s currently not viable yet. Could you test this out, @mrsimb? I’ll get around it to myself once able. Just working extra to make sure the Covid-19 pandemic doesn’t make me homeless if my city goes under lockdown. |
The real problem atm is that every pull request is failing because some of appveyor ci jobs always fail. |
There might be other issues with it too outside of the tests failing. I’m not a full maintainer but am here to assist with getting things working properly. I just don’t have full permissions yet and the main maintainers are trying to get things going as quickly as they can within their means. Thanks for your patience and we’ll get this sorted out as quickly as we’re able. |
Would it be possible to get this change reviewed/fixed soon ? |
It should be noted that node-pre-gyp fixed a double run error so this upgrade would be awesome as otherwise it makes installing this project normally ( Ideally, I'd love to see this backported to the 4.2.0 release series as well. |
|
Fixes #1264 - Installing with --target= results with "Unsupported target version" for targets >= 11