Skip to content

update node-pre-gyp version to ^0.14.0 #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

mceIdo
Copy link

@mceIdo mceIdo commented Dec 19, 2019

Fixes #1264 - Installing with --target= results with "Unsupported target version" for targets >= 11

@mceIdo mceIdo changed the title updated node-pre-gyp version to ^0.14.0 update node-pre-gyp version to ^0.14.0 Dec 19, 2019
@mrsimb
Copy link

mrsimb commented Mar 23, 2020

please review this pull request
i need latest node-pre-gyp to install prebuilt binaries from local path due to corporate firewall issues.

@thearchivalone
Copy link

The problem is: kewde, the maintainer, tried upgrading to that version only to have it break something. He never documented what happened but did close the PR he tried setting up. I don’t know enough about how all of this works yet to be able to know what the issue was but do know it’s currently not viable yet.

Could you test this out, @mrsimb? I’ll get around it to myself once able. Just working extra to make sure the Covid-19 pandemic doesn’t make me homeless if my city goes under lockdown.

@mrsimb
Copy link

mrsimb commented Mar 23, 2020

The real problem atm is that every pull request is failing because some of appveyor ci jobs always fail.
These jobs try to download binaries for electron but the server it downloads from sends 403 error.
I think someone with access to ci config should just disable these jobs so we could continue to receive updates of this library.

@thearchivalone
Copy link

The real problem atm is that every pull request is failing because some of appveyor ci jobs always fail.
These jobs try to download binaries for electron but the server it downloads from sends 403 error.
I think someone with access to ci config should just disable these jobs so we could continue to receive updates of this library.

There might be other issues with it too outside of the tests failing. I’m not a full maintainer but am here to assist with getting things working properly. I just don’t have full permissions yet and the main maintainers are trying to get things going as quickly as they can within their means. Thanks for your patience and we’ll get this sorted out as quickly as we’re able.

@marcpo
Copy link

marcpo commented Apr 6, 2020

Would it be possible to get this change reviewed/fixed soon ?

@MasterOdin
Copy link

MasterOdin commented May 17, 2020

It should be noted that node-pre-gyp fixed a double run error so this upgrade would be awesome as otherwise it makes installing this project normally (npm install) impossible for me if a remote source is not available (#1329).

Ideally, I'd love to see this backported to the 4.2.0 release series as well.

@daniellockyer
Copy link
Contributor

node-pre-gyp has since switched to @mapbox/node-pre-gyp and a version of sqlite3 will be released with this soon 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing with --target=<target-node-version> results with "Unsupported target version" for targets >= 11
7 participants