Update node-gyp in package.json #1361
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cschanaj
reviewed
Nov 4, 2020
package.json
Outdated
| @@ -50,15 +50,15 @@ | |||
| "mocha": "^5.2.0" | |||
| }, | |||
| "peerDependencies": { | |||
| "node-gyp": "3.x" | |||
| "node-gyp": "7.0.0" | |||
There was a problem hiding this comment.
Is there any reason to hard-code version 7.0.0 instead of 7.x ?
|
This closes #1415 |
|
Thank you for your contribution, it has been merged in #1441 along with other changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys!
I update the version of
node-gypfrom3.x.xto7.0.0because the version of node-gyp is old in node_modules of node-sqlite3 when I use it.If you have a request, please let me know. Thank you!