implement exist by jiazhenjiang · Pull Request #604 · TuGraph-family/tugraph-db

jiazhenjiang · 2024-07-19T08:53:51Z

No description provided.

…raph-db into cypher_join_ast

multi match init

wangtao9 · 2024-07-23T05:44:48Z

test/resource/unit_test/expression/cypher/expression.result

 [{"content":"Rachel Kempson","n":{"identity":0,"label":"Person","properties":{"birthyear":1910,"name":"Rachel Kempson"}}},{"content":"Michael Redgrave","n":{"identity":1,"label":"Person","properties":{"birthyear":1908,"name":"Michael Redgrave"}}},{"content":"Vanessa Redgrave","n":{"identity":2,"label":"Person","properties":{"birthyear":1937,"name":"Vanessa Redgrave"}}},{"content":"Corin Redgrave","n":{"identity":3,"label":"Person","properties":{"birthyear":1939,"name":"Corin Redgrave"}}},{"content":"Liam Neeson","n":{"identity":4,"label":"Person","properties":{"birthyear":1952,"name":"Liam Neeson"}}},{"content":"Natasha Richardson","n":{"identity":5,"label":"Person","properties":{"birthyear":1963,"name":"Natasha Richardson"}}},{"content":"Richard Harris","n":{"identity":6,"label":"Person","properties":{"birthyear":1930,"name":"Richard Harris"}}},{"content":"Dennis Quaid","n":{"identity":7,"label":"Person","properties":{"birthyear":1954,"name":"Dennis Quaid"}}},{"content":"Lindsay Lohan","n":{"identity":8,"label":"Person","properties":{"birthyear":1986,"name":"Lindsay Lohan"}}},{"content":"Jemma Redgrave","n":{"identity":9,"label":"Person","properties":{"birthyear":1965,"name":"Jemma Redgrave"}}},{"content":"Roy Redgrave","n":{"identity":10,"label":"Person","properties":{"birthyear":1873,"name":"Roy Redgrave"}}},{"content":"John Williams","n":{"identity":11,"label":"Person","properties":{"birthyear":1932,"name":"John Williams"}}},{"content":"Christopher Nolan","n":{"identity":12,"label":"Person","properties":{"birthyear":1970,"name":"Christopher Nolan"}}},{"content":"New York","n":{"identity":13,"label":"City","properties":{"name":"New York"}}},{"content":"London","n":{"identity":14,"label":"City","properties":{"name":"London"}}},{"content":"Houston","n":{"identity":15,"label":"City","properties":{"name":"Houston"}}},{"content":"Goodbye, Mr. Chips","n":{"identity":16,"label":"Film","properties":{"title":"Goodbye, Mr. Chips"}}},{"content":"Batman Begins","n":{"identity":17,"label":"Film","properties":{"title":"Batman Begins"}}},{"content":"Harry Potter and the Sorcerer's Stone","n":{"identity":18,"label":"Film","properties":{"title":"Harry Potter and the Sorcerer's Stone"}}},{"content":"The Parent Trap","n":{"identity":19,"label":"Film","properties":{"title":"The Parent Trap"}}},{"content":"Camelot","n":{"identity":20,"label":"Film","properties":{"title":"Camelot"}}}]
 MATCH (n {name:'Rachel Kempson'}) RETURN exists((n)-[]->()) /*true*/;
-[{"{EXISTS(NestedPattern(n,@ANON_N1))}":true}]
+[{"exists((n)-[]->())":true}]


where 中的exists 例子在哪，通过了吗

exists中最后一条就是where的例子，已经通过了

wangtao9 · 2024-07-23T05:46:02Z

test/resource/unit_test/expression/cypher/expression.result

+[{"exists((n)-[]->())":true}]
 MATCH (n {name:'Rachel Kempson'}) RETURN exists((n)-[]->(:Person)) /*true*/;
-[{"{EXISTS(NestedPattern(n,@ANON_N1))}":true}]
+[{"exists((n)-[]->(:Person))":true}]


match (a),(b) where not (a)-->(b) return a,b 这种支持吗（不带exists）

目前还不支持，Geax里path并不是个表达式，不能直接放入filter中，要支持这个语句，可以在构造Geax AstNode的时候手动补个Exists，或者扩展Geax AstNode支持path类型的表达式，这个要做的话可以加一下

wangtao9 · 2024-07-23T07:20:20Z

src/core/vertex_index.h

     */
    bool Next();

+    bool Goto(lgraph::VertexId vid);


统一一下 bool Goto(VertexId vid);

已经处理

wangtao9 · 2024-07-23T07:23:57Z

src/cypher/execution_plan/execution_plan_maker.cpp

        ++filter_level_;
    }
    std::reverse(expand_ops.begin(), expand_ops.end());
+    if (ClauseGuard::InClause(geax::frontend::AstNodeType::kExists, cur_types_)) {


这一段逻辑处理的是什么子句，举个cypher语句例子

这段逻辑是在处理 exists部分，用limit和optional算子模拟semiapply。类似下面的查询
MATCH (n {name:'Rachel Kempson'}),(m:City) RETURN exists((n)-[:HAS_CHILD]->()-[:BORN_IN]->(m)) /1 true/;
MATCH (n:Person)-[:BORN_IN]->(c) WHERE exists((n)-[:HAS_CHILD]->()-[:BORN_IN]->(c)) RETURN n,c;

在注释里加上个例子，语句以及对应的plan

cypher ：
MATCH (n {name:'Rachel Kempson'}) RETURN exists((n)-[:MARRIED]->()-[:BORN_IN]->())
plan:
Produce Results
Project [exists((n)-[:MARRIED]->()-[:BORN_IN]->())]
Apply
Limit [1]
Optional
Expand(All) [@ANON_N1 --> @ANON_N3 ]
Expand(All) [n --> @ANON_N1 ]
Argument [n]
Node Index Seek [n] IN []
cypher:
MATCH (n {name:'Rachel Kempson'}),(m:City) RETURN exists((n)-[:HAS_CHILD]->()-[:BORN_IN]->(m))
plan:
Produce Results
Project [exists((n)-[:HAS_CHILD]->()-[:BORN_IN]->(m))]
Apply
Limit [1]
Optional
Expand(Into) [@ANON_N1 --> m ]
Expand(All) [n --> @ANON_N1 ]
Argument [n,m]
Cartesian Product
Node Index Seek [n] IN []
Node By Label Scan [m:City]
cypher :
MATCH (n:Person)-[:BORN_IN]->(c) WHERE exists((n)-[:HAS_CHILD]->()-[:BORN_IN]->(c)) RETURN n,c;
plan:
Expand(All) [n --> c ]
Node By Label Scan [n:Person]
Produce Results
Project [n,c]
Filter [Exists]
Expand(Into) [@ANON_N2 --> c ]
Expand(All) [n --> @ANON_N2 ]
Argument [n,c]

wangtao9 · 2024-07-23T07:28:59Z

src/cypher/resultset/record.cpp

    }
 }

+bool Entry::GetEntityEfficient(RTContext *ctx) const {


Entry::GetEntityEfficient这个方法在做什么？作用？

这个方法是在判断某个record是点或者边，它是不是有效的，有没有保存一个正常的vid或者euid，作用是在exists表达式中判断表达式的结果

spasserby · 2024-07-23T08:05:27Z

src/cypher/execution_plan/ops/op_node_index_seek.h

                            field_, value, value);
        } else {
-            // Weak index iterator
+            // Weak index iterator]


无用的符号

spasserby · 2024-07-23T08:06:43Z

src/cypher/execution_plan/ops/op_expand_all.h

        eit_->FreeIter();
-        neighbor_->PushVid(-1);
+        if (!expand_into_)
+            neighbor_->PushVid(-1);


if (!expand_into_) neighbor_->PushVid(-1);
或者
if (!expand_into_) {
neighbor_->PushVid(-1);
}

已改为第一种方式

spasserby · 2024-07-23T09:15:37Z

src/cypher/resultset/record.cpp

    }
 }

+bool Entry::GetEntityEfficient(RTContext *ctx) const {


这个命名再斟酌一下：
这个是一个校验某个Entity的是否“有效”，不是获取一个Entity

已改为CheckEntityEfficient

spasserby · 2024-07-23T09:30:01Z

src/cypher/execution_plan/execution_plan_maker.cpp

    std::string s = "Execution Plan Before Connect: \n";
-    if (lgraph_log::LoggerManager::GetInstance().GetLevel()
-        == lgraph_log::severity_level::DEBUG) {
+    if (lgraph_log::LoggerManager::GetInstance().GetLevel() == lgraph_log::severity_level::DEBUG) {


这里不太合适：log level不是debug导致 _DumpPlanBeforeConnect 返回结果不同

已经去除if条件

ljcui

本周先不要合入。

jiazhenjiang and others added 30 commits April 1, 2024 15:02

add cypher test compare result

6b4bb7d

Merge branch 'master' into cypher_join_ast

bfa33dd

implement query

cad4c0e

Merge branch 'master' into cypher_join_ast

5d8f2b0

implement match query

50834b1

Merge branch 'master' into cypher_join_ast

8a401fe

Merge branch 'master' into cypher_join_ast

e6dcbeb

implement standalone call and create

3a6f99b

Merge branch 'master' into cypher_join_ast

9b8f1f3

Merge branch 'cypher_join_ast' of https://github.com/jiazhenjiang/tug…

d777633

…raph-db into cypher_join_ast

cpplint

f9e3e4f

cpplint

87e28cf

cpplint

85d95f0

fix double format

271348f

update

37855fb

update

95271e6

implement set

e85b571

implement gql set

df86ed6

Merge branch 'master' into cypher_join_ast

745b791

fix test case

bc09ac1

move dml

15037cc

cpplint

918806e

cpplint

285b8aa

add create delete set

93cd07b

implement unwind

e237903

fix bug

83e342a

implement count(*)

729c1bb

implement expression

f71af20

multi match init

3f27530

Merge pull request #1 from spasserby/multi_match

29a6aed

multi match init

jiazhenjiang added 15 commits June 27, 2024 01:55

fix bug

2f1b503

fix bug

3c19502

fix bug

c7a7e1d

open test case

b50abb5

cpplint

f1a429c

implement exists pattern

24b6a26

implements exists pathpattern

c015e5e

fix bug

a58f1d6

fix bug

0b41329

implement exists in where

7d8e3fe

remove rewriter file

336cf09

remove log

0a1f6bb

add expression test

86876c2

merge master

a365be6

cpplint

de864f9

wangtao9 reviewed Jul 23, 2024

View reviewed changes

spasserby self-requested a review July 23, 2024 07:59

comments

4fbba19

spasserby approved these changes Jul 23, 2024

View reviewed changes

comments

9c5ac27

ljcui self-requested a review July 25, 2024 03:04

ljcui approved these changes Jul 25, 2024

View reviewed changes

spasserby approved these changes Jul 25, 2024

View reviewed changes

jiazhenjiang added 2 commits July 26, 2024 07:32

add comment

83da9d8

cpplint

a465f14

jiazhenjiang enabled auto-merge (squash) July 29, 2024 01:46

wangtao9 and others added 2 commits July 29, 2024 09:55

Merge branch 'master' into exist_path

21fbae5

Merge branch 'master' into exist_path

c38a2bc

jiazhenjiang merged commit d5cda17 into TuGraph-family:master Jul 29, 2024

jiazhenjiang deleted the exist_path branch July 29, 2024 04:33

Conversation

jiazhenjiang commented Jul 19, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ljcui left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants