Skip to content

Add net 5.0 as a target, with updated dependencies #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 3, 2020
Merged

Add net 5.0 as a target, with updated dependencies #203

merged 3 commits into from
Dec 3, 2020

Conversation

JohnCampionJr
Copy link
Contributor

@JohnCampionJr JohnCampionJr commented Nov 20, 2020

Hope I got this right :) All tests pass.

Closes #202

@JohnCampionJr
Copy link
Contributor Author

So apparently GH CI doesn't yet have 5.0 preinstalled, so added it to Actions build flow

@Turnerj
Copy link
Member

Turnerj commented Nov 22, 2020

Strangely I can't get this to build in Visual Studio... I've got the .NET 5.0 SDK installed however something in the build process is stopping it from working.

NETSDK1005 Assets file 'C:\Users\James\Source\Repos\MongoFramework\src\MongoFramework\obj\project.assets.json' doesn't have a target for 'net5.0'. Ensure that restore has run and that you have included 'net5.0' in the TargetFrameworks for your project.

Cleaning the build doesn't work, neither manually deleting the obj and bin folders. Manually running dotnet restore doesn't fix this either for me. So while the code does compile and pass all tests on the CI, if I can't build it locally, I can't work on the library. 😟

This PR might be open for a little while until I can solve this problem on my end.

@JohnCampionJr
Copy link
Contributor Author

That is odd. Compiles on both my Windows and Mac machines. Hope you find the problem.

@Turnerj Turnerj added enhancement Enhancements & features minor-change Minor changes required labels Dec 3, 2020
@Turnerj
Copy link
Member

Turnerj commented Dec 3, 2020

Whatever issue I had before is gone... 🤷‍♂️ Thanks for your work on this - looks good!

@Turnerj Turnerj merged commit 4e1258b into TurnerSoftware:master Dec 3, 2020
@JohnCampionJr JohnCampionJr deleted the net5 branch December 17, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements & features minor-change Minor changes required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add NET 5.0 target
2 participants