Split mapping of EntityDefinition and BsonClassMap #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turnerj
added
enhancement
|
The current changes should get it into a state with general compatibility with common MongoFramework use. Lots of bits and pieces to clean up now associated with this - the various obsolete properties would be a good start. |
These are now considered non-optional and cleans up some default assumptions
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly major change of the internals however will make it possible to support a fluent model building API. The resulting mappings shouldn't be any different to the way they were prior to this PR however any dependency on the entity definition system is likely to have compatibility problems with a number of properties removed as they were obsolete or better expressed an alternative way.
This is effectively only one step of the breaking change as further changes to how indexing works will affect the entity definitions further.