[TypeScript 2] Relative paths in typeRoots not resolved (tsconfig.json)

[elisabethallan]

Hi,

I'm having trouble with type definitions being picked up using TypeScript 2/atom-typescript when the tsconfig.json is not in the same directory as node_modules. I have a src folder containing tsconfig.json, refrencing ../node_modules/@types in the typeRoots, and a Jasmine test in src/app. atom-typescript does not pick up the Jasmine declarations (e.g. describe, it etc) and highlights them as errors.

My folder structure is as follows (some folders removed):

- node_modules
-- @types
- src
-- tsconfig.json
-- app
--- app.component.spec.ts
--- app.component.ts

My tsconfig.json in src is as follows:

{
  "compilerOptions": {
    "declaration": false,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "lib": ["es6", "dom"],
    "mapRoot": "./",
    "module": "es6",
    "moduleResolution": "node",
    "outDir": "../dist/out-tsc",
    "sourceMap": true,
    "target": "es5",
    "typeRoots": [
      "../node_modules/@types"
    ],
    "types": [
      "jasmine"
    ]
  }
}

app.component.spec.ts:

import { AppComponent } from './app.component';

describe('Example', () => {
  beforeEach(() => {
    // Stuff
  });

  it('should create the app', () => {
    expect(true).toBeTruthy();
  });
});

Environment info:

OS: OS X El Capitan 10.11.6
Node.js: 6.3.1
Typescript: 2.0.0
Atom: 1.9.8
atom-typescript: 10.1.6

This configuration works with tsc on the command line (either tsc -p src in the project root, or tsc -p . in src). It also works in atom-typescript if I put the entire path in typeRoots - e.g. /Users/sean/someProject/node_modules/@types - which makes me think that this is an atom-typescript specific issue in resolving relative paths.

Is this a bug or just something I'm doing wrong with my config?

[selkinvitaly]

Yes, I confirm it.

My environment:

OS: Debian x64 stretch
Node.js: 5.11.0
Typescript: 2.1.0-dev.20160812
Atom: 1.5.3
atom-typescript: 10.1.6

[superchris]

Also seeing the same thing. OSX, node v 5.1

[oailloud]

Same thing here, none of the jasmine types are resolved.
I confirm it's working when typeRoots is set to the absolute path to node_modules/@types (with jasmine listed in types) in the tsconfig.json.
OS : Fedora 24
Node v6.6.0
NPM 3.10.3
Atom 1.9.9
atom-typescript 10.1.6

[spali]

similar problem with angular2-seed project (mgechev/angular2-seed).
type core-js not recognized by atom typescript.
defined in src/client/tsconfig.json with

    "typeRoots": [
      "../../node_modules/@types",
      "../../node_modules"
    ],
    "types": [
      "core-js",
      ...

Array.from or Object.assign etc. is not recognized when used.
if I replace the the relative path in typeRoots with absolute path, it works.

OS: Windows 7
Node: 5.6.0
NPM: 3.10.8
Atom: 1.10.2
atom-typescript: 10.1.7

[jorgeas80]

Having the same problem with jasmine, but in VSCode. I don't know if ts plugin for VSCode and for atom are related, but looks suspicious...

[chrissloan]

Same issue here. To fix this as a hack until plugin is changed, I pulled in the node_modules/@types directory to be direct relative to the tsconfig.json file. Looking at the source code for the atom package, there is a default typeRoots path that is always set in relation to the read tsconfig file. I wonder if this is the issue as it does not get overwritten.

Seems dirty, but works and the Angular-cli project I am running does not care as it still looks to the node_modules directory outside the src directory.

[iamolivinius]

Looks like this is the same issue I'm facing right now.

Excluding node_modules due to performance issues results in compiler errors within atom-typescript only.

In the screenshot you can see that [email protected] as well as [email protected] compile the same code without any problems (as it should be). Browserify with tsify don't throw any errors either.

[addisonj]

I am having the same issue as @iamolivinius. This issue only started when I migrated a few projects to go from storing typings in ./typings' in the root of my project to primarily using TS 2.0@typesin node_modules. If I removenode_modules` from my excluded list, it works, but that just kills the performance of atom-typescript...

Not sure if this is new with typescript 2.0, but in tsconfig, if you don't set exclude it by defaults excludes node_modules as well as any outDir specific, which is exactly the behavior I want but it doesn't seem like atom-typescript follows it.

[nycdotnet]

I think this is definitely a bug - or rather it had been implemented correctly and then the new functionality of TypeScript wasn't accounted for. PRs definitely accepted.

[nikoTM]

This works as a temporary solution for me:

  "exclude": [
    "!/node_modules/@types"
  ]

[spali]

Did not work for me in the angular2-seed project (mgechev/angular-seed) I mentioned.
But the following workaround did it:

in src/client/tsconfig.json change

    "typeRoots": [
      "../../node_modules/@types",
      "../../node_modules"
    ],
    "types": [
      "core-js",
      ...

to

    "baseUrl": "../../",
    "typeRoots": [
      "node_modules/@types",
      "node_modules"
    ],
    "types": [
      "core-js",
      ...

[jhm-ciberman]

+1

[Shijir]

Using include instead of exclude is working too:

{
    "compilerOptions": {
        "target": "es5",
        "module": "commonjs",
        "moduleResolution": "node",
        "sourceMap": true,
        "emitDecoratorMetadata": true,
        "experimentalDecorators": true,
        "removeComments": false,
        "noImplicitAny": false,
        "typeRoots": [
            "node_modules/@types"
        ],
        "types": [
            "jasmine",
            "node",
            "core-js",
            "selenium-webdriver"
        ]
    },
    "include": [
        "src/**/*.ts",
        "node_modules/@types"
    ],
    "atom": {
        "rewriteTsconfig": false
    }
}

[kamok]

@Shijir I can confirm removing the exclude array fixed it for me. Thanks.