Skip to content

Block comment: use // instead of /* */ #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markogresak opened this issue Jul 30, 2015 · 3 comments
Closed

Block comment: use // instead of /* */ #507

markogresak opened this issue Jul 30, 2015 · 3 comments

Comments

@markogresak
Copy link
Contributor

I am setting up my atom typescript workflow again after formatting my computer and I can't figure out how to make cmd + / perform a block comment by adding // before each of line instead of creating an actual block comment.

What happens:
Initial state:

line 1
line 2
line 3

Comment block (cmd + /) action:

/*line 1
line 2
line 3*/

What I would like to do:

// line 1
// line 2
// line 3

I'm used to this from other grammars with this style of comments because if I want to uncomment only one line, I don't have to modify anything other line. If I would do the same for line 3, I have to change line 1 and line 3 first.

I am sure I had this functionality before, but I haven't been using atom-typescript for almost two months and now I can't find where to enable it again.

@basarat
Copy link
Member

basarat commented Jul 30, 2015

I am sure I had this functionality before, but I haven't been using atom-typescript for almost two months and now I can't find where to enable it again.

Probably broke post this : #418

Note the .js files behave that way in atom i.e. we get multiple // and we should be consistent with that.

@isuda has raised the same issue privately with me. Marking as a bug 🌹

@markogresak
Copy link
Contributor Author

Sorry for two referenced messages, I later amended commit message and github still recorded it as 2.

basarat added a commit that referenced this issue Jul 31, 2015
🐛 fix comment string as pointed out in #507
@markogresak
Copy link
Contributor Author

Since #508 was pulled, this is resolved.

@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants