Skip to content

Fix the custom path to typescriptServices.js feature #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2016

Conversation

guncha
Copy link
Contributor

@guncha guncha commented Oct 30, 2016

  • All compiled assets are included (atom packages are git tags and hence the built files need to be a part of the source control)

Code run with vm.runInContext is not wrapped with the helper that sets __dirname and __filename variables so it was throwing an error. A simple require is all that's needed in this case.

@guncha guncha merged commit bac8a08 into master Nov 7, 2016
@guncha guncha deleted the fix-custom-path-to-ts branch March 20, 2017 00:53
@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant