Skip to content

Support for tsconfig.json #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 86 commits into from
Oct 7, 2015
Merged

Support for tsconfig.json #275

merged 86 commits into from
Oct 7, 2015

Conversation

nycdotnet
Copy link
Contributor

This PR adds tsconfig.json support and represents a significant refactoring of grunt-ts.

Documentation is here: #202

To Do:

  • Refactor parameters from task and target
  • Refactor vs implementation
  • Add fast unit testing support for gruntfile, vs, and tsconfig.json
  • Implement tsconfig.json support for compilerOptions
  • Implement tsconfig.json support for files
  • Implement tsconfig.json support for exclude array.
  • ignoreFiles
  • templates working for vs, tsconfig, and other parameters
  • warn on incorrect positioning of grunt-ts related configuration items in gruntfile
  • fix simple capitalization issues on grunt-ts related configuration items in gruntfile
  • implement ignoreSettings
  • implement overwriteFilesGlob
  • implement updateFiles
  • implement passThrough
  • fix warnings that were removed (look through integration tests in the gruntfile and re-implement using the new optionsResolver mechanism).
  • update documentation.

return success;
});
}
else {
// Nothing to do
grunt.log.writeln('No files to compile'.red);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this error will trigger in the tsconfig passThrough case. Perhaps another || clause for that case?

@Eyas
Copy link

Eyas commented Oct 3, 2015

@nycdotnet I left a few comments on bugs with the passThrough case for tsconfig

@nycdotnet
Copy link
Contributor Author

Thanks. Will address this soon.

@nycdotnet
Copy link
Contributor Author

@Eyas - I released [email protected] which addresses these comments. Would you please see if this resolves your issue? Thanks.

@nycdotnet nycdotnet changed the title [WIP] Support for tsconfig.json Support for tsconfig.json Oct 7, 2015
@nycdotnet nycdotnet merged commit 3faaa20 into master Oct 7, 2015
@nycdotnet nycdotnet deleted the SupportTsConfig branch March 13, 2016 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants