Skip to content

fix: remove specific version of typescript from dependencies #556

Closed
@Hotell

Description

@Hotell

Suddenly all my builds started to fail https://github.com/Hotell/typescript-lib-starter/pulls

The culprit here is typedoc becuase it has specific version of typescript as direct project dependencies which overrides local node_modules/.bin/tsc symlink to use this TS instead of TS that is used by the project.

This is a big deal.

image

How to fix this:

  • move typescript to peerDependencies ( best solution ) ( this would be a breaking change for your library from perspective of semver )
  • change typescript version in your depencies to ^2.3.4

I can submit PR if you're willing to go through it and merge it eventually after LGTM :)

cheers

Metadata

Metadata

Assignees

No one assigned

    Labels

    wontfixDeclining to implement

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions