-
-
Notifications
You must be signed in to change notification settings - Fork 735
20x slowdown compared to 0.11.x #975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the report. I wonder if this is a windows focused issue. Related to #960 |
I think this must be a windows issue, I haven't run into it. Thanks for the reproduction! Time to pull out |
|
Finally getting back to this, and I still have absolutely no clue why updating to TS 3.x causes this major slowdown when compilation speed remains essentially constant. The Chrome devtools simply can't handle TypeDoc when trying to parse the above file. I get a hard crash as soon as the profiling is complete, which is making this more difficult than it ought to be. Even the built in profiler with Despite this, I have managed to discover a few performance issues which let me reduce the runtime of the 20x slower code to 15x slower... which obviously isn't great. I'm still missing the core issue. Hopefully I'll be able to discover what exactly is happening with more investigation. |
It is used in getChildByName to search children, which led to *always* searching all children, which is especially problematic for any deeply nested structures. Improves convert time by 25% on the monaco.d.ts file in #975
* Allow TraverseCallback to bail out early It is used in getChildByName to search children, which led to *always* searching all children, which is especially problematic for any deeply nested structures. Improves convert time by 25% on the monaco.d.ts file in #975 * Fix coverage report
Well, whatever the issue was... we're back to being pretty fast.
|
Expected Behavior
Typedoc works as before, and takes reasonable time to execute.
Actual Behavior
Typedoc is super super slow, going from 2.5s (v0.11.1) to 49s (v0.14.2).
Steps to reproduce the bug
monaco.d.ts
- monaco.d.ts.txtEnvironment
The text was updated successfully, but these errors were encountered: