Skip to content

Only apply exclusion rules when available #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2017

Conversation

jason0x43
Copy link
Contributor

A recent change to the exclusion logic causes all files to be excluded by default (files are only added to the input list if an exclude rule is provided and it doesn't match). This PR causes files to be added to the input list if there is no exclude rule or if the provided exclude rule doesn't match a file.

@aciccarello
Copy link
Collaborator

Thanks! Could you also add a unit test to make sure that this error doesn't happen again?

@jason0x43
Copy link
Contributor Author

Will do

@aciccarello
Copy link
Collaborator

This should fix #421

Check that exclusion rules are applied (or not applied) to both file and
directory input lists.
@jason0x43
Copy link
Contributor Author

I updated the unit tests to check that the exclusion rules are applied properly to both directory and file entries. The reason the tests were passing the after the initial update is that exclusion was handled different if entries in the input list were directories vs files, and the tests were only trying directories.

@jason0x43
Copy link
Contributor Author

I'm not entirely sure that this will deal with #421. At least, the issue I was experiencing is that 0.5.6 wasn't pulling in any files (vs #421 saying that extra files were being pulled in) because all individual input files were being excluded if no exclude rule was provided.

@blakeembrey blakeembrey merged commit 7134401 into TypeStrong:master Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants