Skip to content

Change the pattern of --exclude option to Regular Expression #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

JohnKoutsoumpas
Copy link

@JohnKoutsoumpas JohnKoutsoumpas commented Apr 10, 2017

The minimatch glob pattern does not properly support multiple exclusions other than a simple (this|that) which is not enough if you need to exclude multiple directories and subdirectories. A good solution to this is to change from a minimatch glob pattern to a Regular Expression pattern which is more powerfull and can almost match anything.

Please consider accepting this as it doesn't affect anything other than this file matching and makes it considerably more powerful.

@blakeembrey
Copy link
Member

It does support it, you can do something like {this,that/bar/**} I believe. Either way, I'm 👎 on this PR as it'll break every current user using this feature and minimatch patterns as well-used and understood for CLI tools.

@JohnKoutsoumpas
Copy link
Author

That's fine. If the globbing does support it then that is great but I couldn't manage to make it work and I've spent hours trying. I'll try it with your suggestion.

@JohnKoutsoumpas
Copy link
Author

Success! Your suggestion worked well, thanks. I'll just close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants