Skip to content

Add option to remove doublequotes in module names in TOC #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nicknisi
Copy link
Collaborator

@nicknisi nicknisi commented Jun 9, 2017

add externalModulesOnly option (boolean) which, if true, will not wrap module names in doublequotes. I was researching why these names are wrapped in quotes and stumbled across #68 discussing this issue, which suggested a possible CLI flag to disable this functionality if desired.

Here's a screenshot of the change in a project where I am not using namespaces (internal modules).

napkin 06-09-17 3 04 00 pm

Also, I'm open to alternatives for the name of the option. Some others I've thought of include

  • assumeNoNamespace
  • removeQuotes
  • externalModules

Any help on the naming would be greatly appreciated.

add externalModulesOnly option (boolean) which, if true, will not wrap
module names in doublequotes.
@aciccarello
Copy link
Collaborator

Yes! I think it would be great to get rid of those quotes. Honestly I'd like them to be off by default.

@nicknisi
Copy link
Collaborator Author

I would too 😄, honestly. It looks like they are there to distinguish namespaces (formerly internal modules) with external modules (using the ESM export keyword. I personally don't use namespace all that often, so I'm not sure how big of an issue that would be to turn them off by default.

@blakeembrey
Copy link
Member

Is there any way we can check if a "module" is external (e.g. in that case, node.js fs) or internal?

@jaredcnance
Copy link

has this PR been abandoned? what still needs to be done to get this cleaned up?

@nicknisi
Copy link
Collaborator Author

Oh wow, sorry I never followed up. I'll re-orient myself and follow up properly.

@nicknisi nicknisi closed this May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants