-
-
Notifications
You must be signed in to change notification settings - Fork 737
dependencies updated #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependencies updated #744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. I'm not sure that this will get merged (it'll probably be included with some other changes) but I'll leave it open for now.
@@ -71,9 +71,10 @@ | |||
"LICENSE" | |||
], | |||
"scripts": { | |||
"test": "mocha -t 10000 dist/test", | |||
"test": "mocha -t 10000 --exit dist/test", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Didn't realize that got changed in mocha 4. The grunt mocha change may need to be changed too.
Is there anything in particular holding this up? |
if you updated typescript that's fine for me, thanks! |
@aciccarello If you're going to close other PRs for updating the TS version in favor of this PR, could you merge this one? This typescript version seems to be causing issues with many other dependencies. 2.8 and 2.9 work fine. |
I'd like to make a suggestion, however I know very little about this project and how typescript is integrated so please take it with a grain of salt. What if, instead of shipping a specific version of TypeScript, TypeDoc used the version that was already installed in the user's project. This way the output of the documentation matches closer to the original types the user declared and users don't need to open an issue every time there is a minor version change to Typescript. Now I imagine this wouldn't be easy to accomplish given that differences in API and features between versions. However other communities have managed to solve this through the use of version specific abstractions. Take Enzyme (React Testing Library) for example, they have separate "Adapters" for each React version to ensure compatibility. |
Is it really necessary to support node.js version 4 ? is quite old / deprecated so before investigating why is failing I'm asking. BTW I updated all dependencies, among then TypeScript to 2.9.2. Thanks |
The last release was 4 months ago. Can we please merge and release this PR? The delays on merging and releasing this is causing TypeDoc to become obsolete and seemingly development stagnant. Both material-ui and react-redux typings break this, and those are two very common and large libraries. I cannot hold back using dependencies that are actually used in my production builds just to have auto-generated docs, but would like to use this. Can we either:
|
Just updating dependencies (mostly typescript) solved an exception when generating using --includeDeclarations. Pasting the exception just in case: