Remove Grunt #933
Merged
Remove Grunt #933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use npx mocha to do the equivolent command
aciccarello
approved these changes
Mar 22, 2019
| "test": "grunt test", | ||
| "build": "grunt build_and_test", | ||
| "pretest": "node scripts/copy_test_files.js", | ||
| "test": "nyc --reporter=html --reporter=text-summary mocha --timeout=10000 dist/test/*.test.js", |
There was a problem hiding this comment.
Nice coverage reporting!
package.json
Outdated
| "clean": "rm -rf node_modules package-lock.json lib coverage .tscache" | ||
| "prepublishOnly": "npm run lint && npm run build_and_test", | ||
| "prepare": "npm run build", | ||
| "mocha": "mocha", |
There was a problem hiding this comment.
I'm dropping this since you can run npx mocha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, Grunt is no longer required.
Additions:
npm run test:ts- Run tests withts-nodeto avoid a pre-compile step.scripts/*.js- Scripts to replace grunt tasks.Changes:
npm run buildno longer also runs tests, usenpm run build_and_testto also run tests.Removals:
Closes #836