Skip to content

Conversation

@Ales315
Copy link
Contributor

@Ales315 Ales315 commented Feb 3, 2025

This fix is based on the code of this PR again from TeamNewPipe TeamNewPipe/NewPipeExtractor#1271
A bit rough cosmetically-wise but it's the best I could do 😀

Note that if the structure of the json changes this solution can fail as the extraction logic is hardcoded.

Closes #868

@Jacobwasbeast
Copy link

I can confirm, it did fix the 'sign in' error on my app.

@Tyrrrz Tyrrrz changed the title Extract visitor data from youtube API Extract visitor data from YouTube API Feb 3, 2025
@Tyrrrz Tyrrrz requested a review from Copilot February 3, 2025 17:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

YoutubeExplode/Bridge/VisitorData.cs:86

  • The error message 'Failed to fetch visitor data' is unclear. It should include more context about the failure, such as the URL or response status.
throw new Exception("Failed to fetch visitor data");

YoutubeExplode/Bridge/VisitorData.cs:44

  • The new behavior introduced by the function 'ExtractFromYoutube' should be covered by tests to ensure it works as expected.
public static async Task<string> ExtractFromYoutube(HttpClient http)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error : Video 'xx_XXXxXxxX' is unplayable. Reason: 'Please sign in'

3 participants