Skip to content

Conversation

@zmx721
Copy link
Contributor

@zmx721 zmx721 commented May 2, 2025

No description provided.

@zmx721 zmx721 requested a review from joelostblom May 2, 2025 20:20
@github-actions
Copy link

github-actions bot commented May 2, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-07-15 11:23 UTC

@joelostblom joelostblom requested a review from sandygross May 30, 2025 18:16
# Plot your confusion matrix on your test set
____
# Leave the following line commented out for the checking purposes. Uncomment to see the plot.
#plt.show()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied over the solution to the exercise field but I am getting this error: "Error while checking multi_class_revised: "You need to plot a confusion matrix.""

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the error message to make it clearer that we need to comment out plt.show() for checking purposes.

<iframe
class="video"
src="https://www.youtube.com/embed/JK9569FeWLg"
title="Module 8 Video - What Did We Just Learn?"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the video was cut off a few seconds too early and stops mid-sentence at 'We look forward...'. Could we ask the team to adjust it?

<iframe
class="video"
src="https://www.youtube.com/embed/ELIEplv266Y"
title="Module 9 Video - Congratulations!"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here the video seems to finish one min earlier than in the "original version". Is there a reason for that?

@zmx721
Copy link
Contributor Author

zmx721 commented Jun 22, 2025

@sandygross I have addressed all comments except those related to the videos. Please check again. Thank you so much!

Copy link
Collaborator

@joelostblom joelostblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @zmx721 ! Two minor changes requested and then we can merge.

Comment on lines 51 to 61
&nbsp;&nbsp;

<font size="4"><em> predicted(price) = coefficient<sub>bedrooms</sub> x #bedrooms + coefficient<sub>bathrooms</sub> x #bathrooms + coefficient<sub>sqfeet</sub> x #sqfeet + coefficient<sub>age</sub> x age + intercept </em></font>


<font size="4"><em> predicted(price) = 0.03 x #bedrooms + 0.04 x #bathrooms + 0.002 x #sqfeet + -0.01 x #age + intercept </em></font>


<font size="4"><em> predicted(price) = (0.03 x 3) + (0.04 x 2) + (0.002 x 1875) + (-0.01 x 66) + 0 </em></font>

<font size="4"><em> predicted(price) = 3.26 </em></font>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This currently flows together in a way that makes it hard to read:

image

Could you try either adding <br> tags to separate the lines or maybe even formatting as math with surrounding $?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my end, it appears as shown in the screenshot below, before any changes were made. Resizing is also fine.
Screenshot 2025-07-15 at 3 05 25 AM

I added a <br> tag. Does it help on your side?

@zmx721
Copy link
Contributor Author

zmx721 commented Jul 15, 2025

@joelostblom Please check if the issue is fixed. Thank you.

Copy link
Collaborator

@joelostblom joelostblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this looks good now, thank again!

@joelostblom joelostblom merged commit b6142b5 into main Jul 15, 2025
1 check passed
@joelostblom joelostblom deleted the quarto_mod8_mod9 branch July 15, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants