Skip to content

Ensure inherited methods return UXarray objects #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 5, 2025
Merged

Conversation

philipc2
Copy link
Member

@philipc2 philipc2 commented Feb 26, 2025

Closes #985

Overview

  • Added tests to check the return types and preservation of uxgrid for various Xarray methods.
  • Added a uxarray.concat() method that preserves the grid between concatenations

@philipc2 philipc2 added the bug Something isn't working label Feb 26, 2025
@philipc2 philipc2 self-assigned this Feb 26, 2025
@philipc2 philipc2 changed the title DRAFT: Ensure inherited methods return UXarray class DRAFT: Ensure inherited methods return UXarray objects Feb 27, 2025
@philipc2 philipc2 changed the title DRAFT: Ensure inherited methods return UXarray objects Ensure inherited methods return UXarray objects Mar 3, 2025
@philipc2 philipc2 marked this pull request as ready for review March 3, 2025 23:32
@philipc2 philipc2 requested a review from erogluorhan March 3, 2025 23:33
@philipc2 philipc2 requested a review from aaronzedwick March 4, 2025 21:15
Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for addressing this really quick!

@philipc2
Copy link
Member Author

philipc2 commented Mar 5, 2025

Thanks a lot for addressing this really quick!

Thanks for the brisk review!

@philipc2 philipc2 merged commit 9ed7505 into main Mar 5, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.where() returning Xarray objects
2 participants