CURA-12016 improve loading time with many printers #20813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CURA-12016 Add a method to load instances of GlobalStack instead of loading all the ContainerStack and then filtering them. This makes the code more explicit and saves some time.
wawanbreton
changed the title
Contributor
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit a2ed64d. ♻️ This comment has been updated with latest results. |
rburema
approved these changes
Jul 30, 2025
Member
rburema
left a comment
rburema
left a comment
There was a problem hiding this comment.
... I'm very glad _MachineNodeLoadJob is a private class -- due to the way github displays the changes, I thought at first we'd had API-break(s) on our hands 😅
done as part of CURA-12016
HellAholic
deleted the
CURA-12016_improve-loading-time-with-many-printers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds explicit methods to load containers of type GlobalStack, which in some cases avoids loading unnecessary containers to afterwards filter them out.
CURA-12016
Requires Ultimaker/Uranium#1005