Add warning icons for extruder visibility in SimulationView #21152
+48
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces warning icons in the SimulationView menu to indicate when extruder visibility is low or unchecked. Updates layout logic to accommodate the new icons and increments the plugin version to 1.0.2.
Updated the id from lineTypeLabel to SchemeTypeLabel and adjusted references accordingly for clarity and consistency in SimulationViewMenuComponent.qml.
id should start with lowercase
Contributor
Test Results24 506 tests +24 506 24 498 ✅ +24 498 48s ⏱️ +48s For more details on these errors, see this check. Results for commit 89a6708. ± Comparison against base commit db86084. ♻️ This comment has been updated with latest results. |
Updated the warning icon visibility check to only consider extruders that exist in the current printer, preventing false warnings for non-existent extruders.
wawanbreton
requested changes
Nov 26, 2025
Contributor
wawanbreton
left a comment
wawanbreton
left a comment
There was a problem hiding this comment.
Code looks good and I love the idea, the only thing that bothers me is that the warning also appears when the exruder is disabled. Can you fix that ?
Updated warning icon visibility logic to display warnings only for enabled extruders in the simulation view menu. This prevents warnings from appearing for extruders that are not active.
Contributor
Author
|
Although it's in my job description to annoy you, this does not fall within that category xD |
wawanbreton
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces visual warnings in the Simulation View menu to improve user awareness when specific extruder settings might affect the simulation display. The main changes are the addition of warning icons that appear under certain conditions, along with minor layout adjustments and a version bump for the plugin.
User interface improvements:
UM.ColorImage) next to the line type label inSimulationViewMenuComponent.qml, which becomes visible if any extruder is unchecked or has opacity below a threshold. This helps users quickly identify potential issues with extruder visibility.Layout and style adjustments:
Version update:
plugin.jsonfrom1.0.1to1.0.2to reflect the new changes.CURA-12847