Skip to content

TEST#148

Closed
gaurav-nelson wants to merge 2 commits intomainfrom
ekline-test
Closed

TEST#148
gaurav-nelson wants to merge 2 commits intomainfrom
ekline-test

Conversation

@gaurav-nelson
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Also include relevant motivation and context. List any dependencies that are required for this change. Delete any other sections or text that are not relevant.

Fixes # (issue number)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Information

Include any additional information about the pull request here.

@github-actions
Copy link

github-actions bot commented Nov 9, 2025

🌟 EkLine Reviewer

Hello! I’m here to help improve your docs. I’ve reviewed your pull request, and left in-line suggestions for quick fixes. For details, visit the Analytics Page.

For questions or feedback, please email support@ekline.io.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

EkLine

🚫 [EkLine] <EK00037>

'Check Modified Files Only' should use sentence-style capitalization. (EK00037)

### Check Modified Files Only


🚫 [EkLine] <EK00037>

'Follow Redirects' should use sentence-style capitalization. (EK00037)

### Follow Redirects

@@ -266,6 +266,8 @@ The `followRedirects` option controls how Linkspector handles HTTP redirects (e.
- When `followRedirects: false`:
Linkspector will _not_ follow HTTP redirects. If a link returns a redirect status code (e.g., 301, 302, 307, 308), it will be reported as an 'error'. The reported status code will be the original redirect status code (e.g., 301), and the error message will indicate that the link redirected but `followRedirects` was set to `false`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] <EK00005>

Suggestions:

  • Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
  • Prefer English terms over Latin abbreviations. Use 'for example' instead of 'e.g.'. (EK00026)
  • In general, use active voice instead of passive voice ('be reported'). (EK00031)
  • In general, use active voice instead of passive voice ('was set'). (EK00031)

Suggested change
Linkspector will _not_ follow HTTP redirects. If a link returns a redirect status code (e.g., 301, 302, 307, 308), it will be reported as an 'error'. The reported status code will be the original redirect status code (e.g., 301), and the error message will indicate that the link redirected but `followRedirects` was set to `false`.
Linkspector will _not_ follow HTTP redirects. If a link returns a redirect status code (for example, 301, 302, 307, 308), it will be reported as an 'error'. The reported status code will be the original redirect status code (for example, 301), and the error message will indicate that the link redirected but `followRedirects` was set to `false`.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] <EK00031>

Suggestions:

  • In general, use active voice instead of passive voice ('is built'). (EK00031)
  • Try to use 'it's' instead of 'It is'. (EK00033)
  • 'adress' could be a typo. Check the spelling. (EK00300)

2. **Addresses limitations and adds user-requested features**: It is built to adress the shortcomings in [GitHub Action - Markdown link check](https://github.com/gaurav-nelson/github-action-markdown-link-check) and adds many user requested features.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] <EK00037>

'Checking Hyperlinks' should use sentence-style capitalization. (EK00037)

## Checking Hyperlinks

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] <EK00037>

'Default Configuration' should use sentence-style capitalization. (EK00037)

### Default Configuration

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] <EK00037>

'Files to Check' should use sentence-style capitalization. (EK00037)

### Files to Check

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] <EK00037>

'Directories to Search' should use sentence-style capitalization. (EK00037)

### Directories to Search

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] <EK00037>

'Excluded Files' should use sentence-style capitalization. (EK00037)

### Excluded Files

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] <EK00037>

'Excluded Directories' should use sentence-style capitalization. (EK00037)

### Excluded Directories

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] <EK00037>

'Ignore Patterns' should use sentence-style capitalization. (EK00037)

### Ignore Patterns

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] <EK00037>

'Replacement Patterns' should use sentence-style capitalization. (EK00037)

### Replacement Patterns

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [EkLine] <EK00037>

'Alive Status Codes' should use sentence-style capitalization. (EK00037)

### Alive Status Codes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant