Skip to content

Fix XR Tests for 2019.3 #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix XR Tests for 2019.3 #1158

wants to merge 1 commit into from

Conversation

StayTalm
Copy link
Contributor

@StayTalm StayTalm commented Jun 2, 2020

In 2019.3 Device Role got replaced with InputDeviceCharacteristics. Updated XRTests to use Characteristics when working in 2019.3 or greater.

@StayTalm StayTalm requested a review from Rene-Damm June 2, 2020 23:19
@Rene-Damm
Copy link
Contributor

@karljj1 landed a change related to this as part of getting CI back to green. @StayTalm could you merge latest develop and update the PR? Or is it obsoleted by Karl's change?

@StayTalm
Copy link
Contributor Author

StayTalm commented Jun 5, 2020

I'll do a merge, I would like to move away from using Role since it's being deprecated, so I'm trying to set Characteristics directly instead of converting from role to characteristics.

@Rene-Damm
Copy link
Contributor

I'll do a merge, I would like to move away from using Role since it's being deprecated, so I'm trying to set Characteristics directly instead of converting from role to characteristics.

Feel free to redo/change the existing fix.

@unity-cla-assistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jimon jimon force-pushed the Fix-XR-Tests-2019-3 branch from 92f44f3 to 3d121b8 Compare January 23, 2023 15:35
@jimon jimon requested review from jimon and removed request for Rene-Damm January 23, 2023 15:35
@jfreire-unity jfreire-unity added the in-review Issues being reviewed by the Unity maintainers label Mar 3, 2023
@jfreire-unity jfreire-unity self-requested a review March 6, 2023 16:40
@jfreire-unity
Copy link
Collaborator

To be merged in #1655.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-review Issues being reviewed by the Unity maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants