pin pip to 20.2 for now #4694
Merged
pin pip to 20.2 for now #4694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
commented
Nov 30, 2020
| @@ -8,6 +8,7 @@ on: | |||
| - 'gym-unity/**' | |||
| - 'test_constraints*.txt' | |||
| - 'test_requirements.txt' | |||
| - '.github/workflows/pytest.yml' | |||
There was a problem hiding this comment.
Make sure tests rerun if this file changes.
andrewcoh
approved these changes
Nov 30, 2020
pradyunsg
reviewed
Nov 30, 2020
| @@ -44,7 +45,8 @@ jobs: | |||
| run: python -c "import sys; print(sys.version)" | |||
| - name: Install dependencies | |||
| run: | | |||
| python -m pip install --upgrade pip | |||
| # pin pip to workaround https://github.com/pypa/pip/issues/9180 | |||
| python -m pip install pip==20.2 | |||
There was a problem hiding this comment.
Suggested change
| python -m pip install pip==20.2 | |
| python -m pip install pip==20.2.4 |
There was a problem hiding this comment.
Thanks for the suggestion, but I think this is enough for now. Hopefully you'll have a patch release soon :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
pip 20.3 throws an exception trying to install our dependencies. pin to 20.2 until they get a fix
We might need this later for tests that run on yamato, but as of the moment, the pypi mirror we use internally hasn't gotten 20.3
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
pypa/pip#9180
Types of change(s)