Debugger: Prevent Abort on Invalid Virtual Method #2115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Were you able to reproduce this issue with the upstream mono in dotnet/runtime? It doesn't look like this change is there so it might be worthwhile upstreaming the change unless they've fixed it in some other way. |
joncham
reviewed
Mar 3, 2025
| @@ -6545,6 +6545,10 @@ do_invoke_method (DebuggerTlsData *tls, Buffer *buf, InvokeData *invoke, guint8 | |||
| PRINT_DEBUG_MSG (1, "[%p] Error: Interface method invoked without this argument.\n", (gpointer) (gsize) mono_native_thread_id_get ()); | |||
| return ERR_INVALID_ARGUMENT; | |||
| } | |||
| if (!mono_object_isinst(this_arg, m->klass)) { | |||
| PRINT_DEBUG_MSG (1, "[%p] Error: Interface method invoked on object that doesn't implement the interface.\n", (gpointer) (gsize) mono_native_thread_id_get ()); | |||
There was a problem hiding this comment.
Nit, should the message include more info like type and interface/and method name?
There was a problem hiding this comment.
This matches the existing error messages in the file so I'm not planning on changing this.
joncham
approved these changes
Mar 3, 2025
UnityAlex
approved these changes
Mar 4, 2025
scott-ferguson-unity
force-pushed
the
prevent-abort-when-debugger-invokes-method-on-invalid-type
branch
from
a595a75 to
64d1d37
Compare
If the debugger is asked to invoke an interface or virtual method on a class the mono_object_get_virtual_method_internal will assert & abort (or crash). mono_object_get_virtual_method_internal assumes that it is being asked to invoke a virtual method on an instance that implements it. If that's not true it will assert & abort or access invalid memory if assertions are disabled. To protect against this we check if the this_arg can be cast to the interface or base class type. If it can then we should be safe to call mono_object_get_virtual_method_internal.
scott-ferguson-unity
force-pushed
the
prevent-abort-when-debugger-invokes-method-on-invalid-type
branch
from
64d1d37 to
aa9587d
Compare
scott-ferguson-unity
deleted the
prevent-abort-when-debugger-invokes-method-on-invalid-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the debugger is asked to invoke an interface or virtual method on a class the mono_object_get_virtual_method_internal will assert & abort (or crash).
mono_object_get_virtual_method_internal assumes that it is being asked to invoke a virtual method on an instance that implements it. If that's not true it will assert & abort or access invalid memory if assertions are disabled.
To protect against this we check if the this_arg can be cast to the interface or base class type. If it can then we should be safe to call mono_object_get_virtual_method_internal.
Reviewers: please consider these questions as well! ❤️
Release notes
Fixed UUM-97917 @scott-ferguson-unity
Mono: Prevent debugger crash when watching or evaluating an interface property or method without an instance (i.e. nameof(IInterface.Property).