Use ros2_controllers sources #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ros-controls/ros2_controllers#360 already fixed a bug related to parameter handling in forward controllers. Until next sync we have to use the source repo for error-free controller startup.
fmauch
reviewed
Jun 21, 2022
Contributor
fmauch
left a comment
fmauch
left a comment
There was a problem hiding this comment.
As this currently "only" affects the execution tests, we'll need some more work to make this have any effect. The execution test files don't have an upstream workspace defined.
So, in order to help the execution tests succeed, one would have to modify the workflows to use an upstream workspace and I guess, it does make sense to use the not-released files there...
Contributor
Author
|
That makes sense, that would mirror the |
Contributor
|
yes, for the moment that makes sense. |
fmauch
approved these changes
Jun 22, 2022
Contributor
fmauch
left a comment
fmauch
left a comment
There was a problem hiding this comment.
LGTM!
We should remember to revert this after the next sync.
fmauch
added a commit
to fmauch/Universal_Robots_ROS2_Driver
that referenced
this pull request
Jul 11, 2022
This reverts commit 6d13661.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ros-controls/ros2_controllers#360 already fixed a bug related to parameter handling in forward controllers. Until next sync we have to use the source repo for error-free controller startup.