-
-
Notifications
You must be signed in to change notification settings - Fork 202
4.3.0-rc3 #1634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.3.0
Are you sure you want to change the base?
4.3.0-rc3 #1634
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@demiankatz is attempting to deploy a commit to the BL UV team Team on Vercel. A member of the Team first needs to authorize it. |
|
I've been testing RC3 over the past 2 days on both desktop and mobile. I also checked keyboard navigation and screen reader support (NVDA). Everything is working as expected, and A/V loads correctly. I wanted to share a small thought regarding some of the example manifest that don't currently load. It might be worth considering either removing these from the example page or replacing them with manifests that load successfully. From a testing perspective, it can be a bit confusing when some examples don't load, even though the issue appears to be with the manifests themselves rather that the viewer. For reference: These are the manifest that are currently unable to load: British Library National Library of Wales
Bodleian
National Gallery of Art Test
SlideAtlas |
|
@LanieOkorodudu, I am definitely in favor of cleaning up the examples. They are defined here: As a starting point, maybe it's worth opening a PR to simply remove any manifests that are broken links or obvious tests (rather than real-world examples). For the real-world examples that don't work (like the NLW ones you mention), maybe we need to talk to stakeholders and figure out why they are broken. Is there something wrong with the manifests, or did they work at some point in the past and got broken by some UV issue that needs investigation? |
This is the third release candidate for 4.3.0, fixing a bug introduced in RC2 (#1627) and updating further dependencies.
This RC also includes some further adjustments to the release workflow in an effort to get NPM publishing working again; as of this writing, it is still not functional, so this RC has been manually published.