Panel restructure #1635
Draft
Panel restructure #1635
+8,016
−9,006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@jamesmisson is attempting to deploy a commit to the BL UV team Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for a new arrangement of the panel divs that has a few benefits for the feel of UV and for ease of future UI work.
Currently the mainPanel contains leftPanel, centerPanel, and rightPanel as siblings in a row. This means that when left and right panels are opened/closed, the center panel resizes, making the OSD image briefly flicker and transform.
This PR puts the OSD viewer in a new backgroundPanel which sits behind the left, center, and right panels, which are contained in a new overlayPanels div. The centerPanel is used as a transparent container for the various bits and pieces that overlay the image: image control buttons, paging buttons, OSD navigator, page mode buttons. This enables them to behave as authentic overlays rather than the illusion of overlays used in the current version of UV, which I think gives a more polished feel in general and prevents the image flicker on panel resize.
Besides cosmetic improvements, embracing the third dimension will allow more economical use of space when we try different arrangements of the transcription panel UI (e.g. it makes user-resizable panels easier to implement, and allows content to expand over other content if needs be).
Only the OSD extension has been given this treatment here, it currently breaks the AV extensions.
This depends on the new header and buttons PR here: #1557