All commands should work from the Git panel

[jstritch]

Command Name

Add To Last Commit

Steps to Reproduce

1. Stage a modified file.
2. Select the Add To Last Commit command and observe the confirmation dialog does not display the file name.
3. Press the Add To Last Commit button on the confirmation dialog.

Expected Behavior

The commit is amended with the staged files.

Actual Behavior

1. Observe two notifications regarding nothing to commit.
2. The file is no longer staged.

Environment

• OS: Linux Mint 20.2 - Cinnamon
• apm --version:
  • apm 2.6.2
  • npm 6.14.13
  • node 12.14.1 x64
  • atom 1.57.0
  • python
  • git 2.32.0

[UziTech]

When select the Add To Last Commit command (step 2) is the staged file the active file?

The "Add To Last Commit" command (almost all of the commands really) do not act on the staged files but the selected files, the files that are selected in the tree-view or active editors. Actually I think the commit commands actually unstage all files before running the command.

[jstritch]

I initiated the procedure using the Git/GitHub panel on the right. Maybe git-menu shouldn't appear there.

[UziTech]

or we should include git panel in selection. Currently it only checks tree-view or tab selection otherwise falls back to active editor.

[jstritch]

I strongly prefer git-menu be made to work in the git panel.