Fix MvM victory screen player animations

[brokenparts]

Hi. This fixes several visual bugs relating to player animations on the Mann Up victory screen.

Before/After

Demoman with The Bootlegger equipped

Sniper with The Huntsman equipped

Details

This PR essentially just moves the class select animation logic from CTFClassMenu::LoadItems() to a new function CTFPlayerModelPanel::PlayClassSelectAnimation(), which can be used by both the class select menu and the MvM loot screen menu. This allows both menus to reuse the same animation logic, eliminating duplicated and potentially inconsistent code.

Note: As of the current master 39f6dde, this is affected by the class select animation playback bug. This could be resolved by merging my previous PR before merging this one:

• Fix class select animation playback #1285

Testing

To force the loot screen to show on a listen server, change this check to always be true:

source-sdk-2013/src/game/client/tf/tf_hud_mann_vs_machine_victory.cpp

Line 1924 in 39f6dde

if ( TFGameRules() && TFGameRules()->GetCurrentMatchGroup() == k_eTFMatchGroup_MvM_MannUp )

and add this ConCommand:

CON_COMMAND( test_show_mvm_victory_screen, "" )
{
	CTFHudMannVsMachineStatus *pMannVsMachineStatus = GET_HUDELEMENT( CTFHudMannVsMachineStatus );
	if ( pMannVsMachineStatus && TFObjectiveResource() )
	{
		pMannVsMachineStatus->ReopenVictoryPanel();

		CMsgMvMVictoryInfo victoryInfo = CMsgMvMVictoryInfo::default_instance();

		C_BasePlayer *pMe = C_BasePlayer::GetLocalPlayer();
		CSteamID mySteamId = { }; pMe->GetSteamID( &mySteamId );

		CEconItem testItem = CEconItem();
		testItem.SetDefinitionIndex( 169 );
		testItem.SetQuality( AE_SELFMADE );

		CSOEconItem testItemSO = { };
		testItem.SerializeToProtoBufItem( testItemSO );
		std::string test_item_bytes = { };
		testItemSO.SerializeToString( &test_item_bytes );

		for ( int i = 0; i < MVM_PLAYER_COUNT; ++i )
		{
			CMsgMvMVictoryInfo_Player *pVictoryPlayer = victoryInfo.add_players();
			pVictoryPlayer->set_steam_id( mySteamId.ConvertToUint64() );
			pVictoryPlayer->set_badge_level( 12345 );

			for ( int j = 0; j < 5; ++j )
			{
				CMsgMvMVictoryInfo_Item *pItem = pVictoryPlayer->add_items();
				pItem->set_item_data( test_item_bytes );
				pItem->set_grant_reason( j == 0 ? CMsgMvMVictoryInfo_GrantReason_BADGE_LEVELED : CMsgMvMVictoryInfo_GrantReason_MANN_UP );
			}
		}

		pMannVsMachineStatus->MVMVictoryGCResponse( victoryInfo );
	}
};

[rabscootle]

This might be better suited for another (optional) PR, but is there any chance that weapons that cannot use “fancy” class select animations instead have the user perform the taunt matching the currently held weapon?

[brokenparts]

This might be better suited for another (optional) PR, but is there any chance that weapons that cannot use “fancy” class select animations instead have the user perform the taunt matching the currently held weapon?

Sounds like a good idea. This PR is already relatively large, so I'd rather wait and see if this one gets merged before attempting to add anything else.