[ObjC] Use relative pointer types for members of objc_method_entry_t
#6700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emesare
added
File Format: Mach-O
Component: Objective-C Workflow
|
I initially started on this change because I had expected it'd make cross references work for functions / variables that these fields point to. Sadly it does not (#6701). |
bdash
force-pushed
the
objc-relative-pointers
branch
from
33f082a to
e838c00
Compare
bdash
force-pushed
the
objc-relative-pointers
branch
from
e838c00 to
e100369
Compare
bdash
force-pushed
the
objc-relative-pointers
branch
2 times, most recently
from
212f228 to
de51156
Compare
They were previously relying on the Objective-C workflow to render the `rptr_t` typedef. Relative pointer types are now a first class citizen and are rendered correctly without any additional work.
0cyn
force-pushed
the
objc-relative-pointers
branch
from
de51156 to
cf9a634
Compare
|
Thank you so much for the PR and for having it rebased! Greatly appreciated! Merged with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative pointer types have been a first class citizen for some time and are rendered correctly without any additional work.
The code was previously relying on the Objective-C workflow to render the
rptr_ttypedef.Fixes #6699.