[ObjC] Improve naming of arguments to Objective-C methods #6790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdash
force-pushed
the
objc-argument-naming
branch
from
8996cfa to
84db272
Compare
bdash
force-pushed
the
objc-argument-naming
branch
from
84db272 to
f9922fd
Compare
bdash
force-pushed
the
objc-argument-naming
branch
2 times, most recently
from
010bbde to
24d313a
Compare
bdash
force-pushed
the
objc-argument-naming
branch
from
24d313a to
4c0b520
Compare
Detect and remove common prefixes used on selectors so that their argument names are more natural. For instance, a selector of `initWithURL:withStagedURL`: now ends up with arguments named `URL` and `stagedURL`, rather than `initWithURL` and `withStagedURL`.
0cyn
force-pushed
the
objc-argument-naming
branch
from
4c0b520 to
425a1be
Compare
|
Thank you! Merged with 425a1be and expected to be in builds >= |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect and remove common prefixes used on selectors so that their arguments are more naturally named. For instance, a selector of
initWithURL:withStagedURL: now ends up with arguments namedURLandstagedURL, rather thaninitWithURLandwithStagedURL.