-
Notifications
You must be signed in to change notification settings - Fork 11
added cleanup command functionality to cli. #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
- Coverage 89.67% 89.36% -0.31%
==========================================
Files 13 13
Lines 823 884 +61
==========================================
+ Hits 738 790 +52
- Misses 85 94 +9
🚀 New features to boost your workflow:
|
A couple of high level comments:
|
@XkunW Added two commits regarding your comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@XkunW I resolved the conflict with the updated main. Can you please review this again? |
Short Description
This pull request introduces a new
cleanup
command to the CLI, enabling users to remove old log directories with optional filters. It includes updates to the documentation, CLI interface, and client API to support this functionality.New
cleanup
Command Implementation:Added a
cleanup
command to the CLI invec_inf/cli/_cli.py
. This command allows users to filter and remove log directories based on criteria such as--model-family
,--model-name
, and--job-id
. A--dry-run
option is also available to preview deletions without performing them.Implemented the
cleanup_logs
method in theVecInfClient
class invec_inf/client/api.py
. This method handles the logic for finding and deleting log directories, with support for the same filtering options as the CLI command.Added the
find_matching_dirs
utility function invec_inf/client/_utils.py
to locate directories matching the specified filters. This function is used by thecleanup_logs
method to identify directories for deletion.