Skip to content

test: remove pytest-timeout #2795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2022
Merged

test: remove pytest-timeout #2795

merged 2 commits into from
Jan 3, 2022

Conversation

liuverta
Copy link
Contributor

@liuverta liuverta commented Jan 3, 2022

Impact and Context

Effectively reverts #2787 and #2690.

There is some sort of bad interaction between pytest-timeout and pytest-xdist that results in tests crashing. For references, see:

We had added pytest-timeout to fail faster when cases hang indefinitely. We can still rely on the pipeline timeout defined on the Jenkinsfile.

Risks and Area of Effect

Low risk: Nothing is likely to break; it will just take longer for test pipelines to fail on indefinitely-hanging tests (we could tighten the pipeline timeout if we'd like, since xdist is running our suites faster).

Low AoE: Only affects how the client test suite is run (mostly in CI, from reading the above-linked GitHub issues)

Testing

Ran test pipelines, which did not encounter the aforementioned bad interaction.

How to Revert

Revert this PR.

@liuverta liuverta self-assigned this Jan 3, 2022
@liuverta liuverta marked this pull request as ready for review January 3, 2022 18:35
@liuverta liuverta requested a review from conradoverta January 3, 2022 18:35
@liuverta liuverta merged commit 36a9000 into master Jan 3, 2022
@liuverta liuverta deleted the ml/no-timeout branch January 3, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants