test: remove pytest-timeout #2795
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact and Context
Effectively reverts #2787 and #2690.
There is some sort of bad interaction between
pytest-timeout
andpytest-xdist
that results in tests crashing. For references, see:pytest-xdist
breaks asyncio-based code expecting to be run in the main thread pytest-dev/pytest-xdist#620We had added
pytest-timeout
to fail faster when cases hang indefinitely. We can still rely on the pipeline timeout defined on the Jenkinsfile.Risks and Area of Effect
Low risk: Nothing is likely to break; it will just take longer for test pipelines to fail on indefinitely-hanging tests (we could tighten the pipeline timeout if we'd like, since
xdist
is running our suites faster).Low AoE: Only affects how the client test suite is run (mostly in CI, from reading the above-linked GitHub issues)
Testing
Ran test pipelines, which did not encounter the aforementioned bad interaction.
How to Revert
Revert this PR.