Skip to content

Add wasm build tags#87

Merged
f41gh7 merged 2 commits into
VictoriaMetrics:masterfrom
omerfirmak:patch-1
Jul 27, 2025
Merged

Add wasm build tags#87
f41gh7 merged 2 commits into
VictoriaMetrics:masterfrom
omerfirmak:patch-1

Conversation

@omerfirmak
Copy link
Copy Markdown
Contributor

@omerfirmak omerfirmak commented May 27, 2025

Fixes #61

@joshuacolvin0
Copy link
Copy Markdown

This would be helpful for https://github.com/OffchainLabs/nitro as well

@eljobe
Copy link
Copy Markdown

eljobe commented Jul 23, 2025

To add a little context to what @joshuacolvin0 has already mentioned.
We are currently maintaining our own fork of this repo here: https://github.com/OffchainLabs/fastcache essentially, just to add these build tags. It would be much nicer if we could just depend on the official repo, and occasionally pull in the latest version rather than having to maintain this dependency manually.

Copy link
Copy Markdown
Member

@makasim makasim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@makasim makasim requested review from rtm0 and zekker6 July 25, 2025 10:58
Copy link
Copy Markdown
Contributor

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f41gh7 f41gh7 merged commit e274544 into VictoriaMetrics:master Jul 27, 2025
@f41gh7
Copy link
Copy Markdown
Contributor

f41gh7 commented Jul 27, 2025

Thanks for contribution!

@f41gh7 f41gh7 mentioned this pull request Jul 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

can't compile to wasm

5 participants