3.0.0 release candidate feedback

[joelhawksley]

👋🏻 Hi folks! We've shipped a release candidate for ViewComponent v3. Please provide feedback in this issue ❤️

[jcoyne]

I'm not seeing it https://rubygems.org/gems/view_component, did it get pushed?

[joelhawksley]

@jcoyne It's in progress. I wanted to have this issue open to mention in the changelog. 🐔, 🥚 , etc.

[jcoyne]

@joelhawksley got it. Thanks.

[tmaier]

I tried it. Looks good in general.

However, it would be great to have a solution for the forms-issue (ref. #1432 etc.) with this release... and if this means that the documentation just mentions the known and recommended workarounds.

[camertron]

Hey @tmaier, thanks for the reminder re: #1432. A semi-recent change to action view may actually make our job easier with respect to supporting form helpers. I tried running our action view compatibility tests on Rails main, but they all failed, so the Rails change alone isn't enough. I'll try having a look at this in more depth tomorrow. Regardless, I don't think form helper compatibility should block the v3 release.

[jacob-carlborg-apoex]

I found a minor issue that probably needs a breaking change to be fixed: #1641. Would be nice to have a fix included in v3.

[tmaier]

The most simple approach on #1432 is to improve documentation. I opened a small Pull Request (#1644).

[barmintor]

I'm running a test against the RC, and I'm seeing a failure that would be explained by the collection counter param changing to a 0-indexed value rather than a 1-indexed value. Is that a documented change?

(EDIT: the tests are fine against 2.82.0 as far as I can see)

[barmintor]

LOL yes, it is a documented change. Thanks!

[jacob-carlborg-apoex]

The changelog says:

Remove deprecated rendered_component in favor of rendered_content

But rendered_content is marked as @private and the deprecation message says to use page instead of rendered_component (although they're no exactly the same).

[Spone]

Happy to report that tests pass on view_component-form, when running view_component v3.0.0.rc1!

[jdelStrother]

Would v3 be a good point to discuss #1528 again to avoid Rails initialization-order problems?