Introduce BuildInfo #2249
Merged
Introduce BuildInfo #2249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaciejG604
force-pushed
the
build-info
branch
5 times, most recently
from
874ae33 to
d4c6364
Compare
|
Based on discussion in #2051, I think that the |
MaciejG604
force-pushed
the
build-info
branch
4 times, most recently
from
ad2ded3 to
310c056
Compare
Closed
MaciejG604
force-pushed
the
build-info
branch
2 times, most recently
from
d6e526e to
4736003
Compare
lwronski
reviewed
Jul 19, 2023
lwronski
reviewed
Jul 20, 2023
lwronski
reviewed
Jul 20, 2023
modules/integration/src/test/scala/scala/cli/integration/RunTestDefinitions.scala
Outdated
Show resolved
Hide resolved
MaciejG604
force-pushed
the
build-info
branch
2 times, most recently
from
c202c8a to
4b32166
Compare
tgodzik
reviewed
Jul 20, 2023
modules/directives/src/main/scala/scala/build/preprocessing/directives/ComputeVersion.scala
Outdated
Show resolved
Hide resolved
tgodzik
reviewed
Jul 20, 2023
modules/build/src/test/scala/scala/build/tests/SourceGeneratorTests.scala
Outdated
Show resolved
Hide resolved
MaciejG604
force-pushed
the
build-info
branch
2 times, most recently
from
3a9f0a2 to
71fb6d2
Compare
|
ComputeVersion is now moved to a different branch and will be a follow-up PR to this one |
MaciejG604
force-pushed
the
build-info
branch
2 times, most recently
from
56a06b4 to
2ad0dfc
Compare
lwronski
approved these changes
Jul 24, 2023
modules/directives/src/main/scala/scala/build/preprocessing/directives/BuildInfo.scala
Outdated
Show resolved
Hide resolved
tgodzik
reviewed
Jul 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2106
As well as moves the wrapper generation to the step when Sources are created from ScopedSources