Add warning about test files in publish docs #3486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majk-p
commented
Feb 10, 2025
Gedochao
reviewed
Feb 11, 2025
There was a problem hiding this comment.
Thanks for the contribution! I left some suggestions.
Note: the PR currently targets the main branch, which means the changes would only be reflected on the docs website after the next release.
Since no code changes were included, just plain docs, optimally it'd target the stable branch.
https://github.com/VirtusLab/scala-cli/blob/main/CONTRIBUTING.md#stable-and-documentation-changes
majk-p
force-pushed
the
publishing-test-scope-docs
branch
2 times, most recently
from
cd8bd27 to
a3b477d
Compare
|
Ah, right. |
majk-p
force-pushed
the
publishing-test-scope-docs
branch
from
a3b477d to
d19b369
Compare
|
Yeah, that's what I did but I must've messed something |
majk-p
force-pushed
the
publishing-test-scope-docs
branch
from
d19b369 to
e369133
Compare
|
Tracking of stable branch was broken on my fork, but it should be fine now |
Gedochao
approved these changes
Feb 11, 2025
Mee-Tree
pushed a commit
to Mee-Tree/scala-cli
that referenced
this pull request
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies the publishing docs to avoid misconceptions as raised in #3483