Support links in using file directive (implements #1328) #3681
Conversation
Co-authored-by: Michał Pawlik <[email protected]> Co-authored-by: tgodzik <[email protected]>
|
|
|
@majk-p @tgodzik It works! Indeed, dependencies are resolved recursively already.
|
|
Note: need to fix formatting & regenerate reference docs for the CI to pass. |
| // TODO: reuse existing one? e.g. scala.cli.commands.shared.SharedOptions.coursierCache | ||
| lazy val fileCache: FileCache[coursier.util.Task] = FileCache() |
There was a problem hiding this comment.
Yup, I think it's accurate that SharedOptions.coursierCache should be used.
| private def downloadFile(pUri: Positioned[java.net.URI]) = | ||
| import scala.build.options.ScalaVersionUtil.fileWithTtl0 | ||
| val artifact = Artifact(pUri.value.toString).withChanging(true) | ||
| fileCache.fileWithTtl0(artifact) | ||
| .left | ||
| .map(err => | ||
| new MalformedDirectiveError(err.describe, pUri.positions) | ||
| ) // TODO: better error type | ||
| .map(f => os.read.bytes(os.Path(f, Os.pwd))).map(content => | ||
| Seq(Virtual(pUri.value.toString, content)) | ||
| ) |
There was a problem hiding this comment.
This is very similar to SharedOptions.downloadInputs... I wonder if the function itself could be passed all the way here, rather than the cache
| new MalformedDirectiveError(err.describe, pUri.positions) | ||
| ) // TODO: better error type |
There was a problem hiding this comment.
just a new error class would do, I think
Scala Tooling Spree 15.05
see #1328