feat(ruleset): modernize class structure and replace legacy commenting sniffs #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g sniffs - Update ClassStructure to enforce grouping for PHPUnit fixtures and DI methods. - Disable rigid Squiz commenting sniffs; reliance shifted to Slevomat and types. - Allow fully qualified global functions and constants in ReferenceUsedNamesOnly. - Add DisallowVariableVariable and EmptyLinesAroundClassBraces sniffs. - Relax multi-line method signature constraints and increase namespace spacing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This update modernizes the WPTechnix coding standards to better align with PHP 8.1+ features and Slevomat's capabilities.
Class Structure Updates
setUp,@before, data providers, andinject*methods inSlevomatCodingStandard.Classes.ClassStructure.Commenting & Formatting
Squizcommenting rules (File, Function, Block comments). These are now considered redundant asSlevomathandles docblock spacing, and Modern PHP types/attributes provide self-documentation.ReferenceUsedNamesOnlyto allow fully qualified global functions/constants (e.g.,\strlen()), improving performance and clarity.EmptyLinesAroundClassBraces(0 lines) and increased namespace spacing.Safety
SlevomatCodingStandard.Variables.DisallowVariableVariableto prevent unsafe dynamic variable usage.