ci: add standard and plus feature sets #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
why test failed on gh action？ |
Member
Author
|
i think test_ssh3 is expected to fail as it's interactive auth? test_ssh2 I have no idea - @VendettaReborn should this pass ? |
clash_lib/src/proxy/ssh/mod.rs
Outdated
| #[cfg(target_os = "linux")] | ||
| #[tokio::test] | ||
| #[serial_test::serial] | ||
| #[ignore = "failed on github actions"] |
Contributor
There was a problem hiding this comment.
CROSS_CONTAINER_OPTS="--network host" CLASH_DOCKER_TEST="true" cross test --workspace --exclude clash_ffi --target x86_64-unknown-linux-gnu --all-features test_ssh
i have tested the previous fix on my machine, and it seems totaly fine
ibigbug
commented
Feb 13, 2025
Signed-off-by: Yuwei Ba <[email protected]>
Signed-off-by: Yuwei Ba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge