Skip to content

Conversation

@lmmqxyx404
Copy link
Contributor

As title described

@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 20.93023% with 34 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
clash_lib/src/proxy/tun/inbound.rs 0.00% 30 Missing ⚠️
clash_lib/src/config/def.rs 0.00% 3 Missing ⚠️
clash_lib/src/config/internal/config.rs 90.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Itsusinn
Copy link
Member

Itsusinn commented Mar 12, 2025

fd://345 is working on Android.
You might need impl different default values for device-id: Option<Url>.

Return Err on android for example (on android clash-rs cannot create tun by itself). It must be configured outside

@ibigbug
Copy link
Member

ibigbug commented Mar 17, 2025

@lmmqxyx404 does this resolve your concern?

@ibigbug ibigbug requested a review from Itsusinn March 17, 2025 15:52
Itsusinn
Itsusinn previously approved these changes Mar 18, 2025
@lmmqxyx404
Copy link
Contributor Author

OK

@ibigbug ibigbug changed the title feat(tun): maintain the compatability with mihomo feat(tun): add default tun device name Mar 19, 2025
@ibigbug ibigbug enabled auto-merge (squash) March 19, 2025 12:58
@ibigbug ibigbug merged commit 153fb70 into Watfaq:master Mar 19, 2025
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants