Skip to content

Conversation

@ibigbug
Copy link
Member

@ibigbug ibigbug commented Apr 16, 2025

🤔 This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

#778

💡 Background and solution

📝 Changelog

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Changelog is provided or not needed

@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
clash_lib/src/config/internal/convert/listener.rs 60.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ibigbug ibigbug merged commit 76e1309 into master Apr 17, 2025
32 checks passed
@ibigbug ibigbug deleted the fix-global-allowlan branch April 17, 2025 02:42
@Itsusinn
Copy link
Member

Itsusinn commented Apr 20, 2025

I think this leads to inconsistent behavior between clash-rs and clash-meta.
Some users might want one inbound allow lan, meanwhile another disallow lan.
In former implemention, every inbound has its own allow-lan.
Tho clash-meta use global allow-lan, it can use bind to forcing listener listen on a non-local ip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants