feat(proxy): add shadowquic protocol #784
Merged
+862
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
ibigbug
reviewed
May 1, 2025
| use crate::{Error, common::utils::default_bool_true, config::utils}; | ||
| use serde::{Deserialize, de::value::MapDeserializer}; | ||
| use serde_yaml::Value; | ||
| use shadowquic::config::CongestionControl as SQCongestionControl; |
Member
There was a problem hiding this comment.
you may need to gate the feature here to pass the build
Contributor
Author
There was a problem hiding this comment.
Done in latest commit
| ) -> io::Result<&ShadowQuicClient> { | ||
| self.ep | ||
| .get_or_try_init(|| async { | ||
| let iter: Vec<&str> = self.opts.addr.split(":").collect(); |
Member
There was a problem hiding this comment.
is it an issue if opts.addr is an ipv6 address?
Contributor
Author
There was a problem hiding this comment.
Indeed, this is a true bug. solved in latest commit
| impl DialWithConnector for Handler {} | ||
|
|
||
| #[async_trait] | ||
| impl OutboundHandler for Handler { |
Member
There was a problem hiding this comment.
mind adding a test like other outbounds did?
Contributor
Author
There was a problem hiding this comment.
Done in latest commit
Member
|
Whats wrong with those failed targets? |
Member
|
I think it's the missing feature gate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
Hello, this PR implements shadowquic protocol which works similarly to shadowtls but more suitable for QUIC.
I tested personally with socks inbound and TCP/UDP seems to work. Test and doc are not added yet.
TODO
📝 Changelog
☑️ Self-Check before Merge