-
-
Notifications
You must be signed in to change notification settings - Fork 342
Add DBM_TimerUpdateIcon event listener #4916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
That still isn't enough, no one is reacting to these events. I would finish the PR, if you tell me how to reproduce the issue easily. |
|
I've updated the description of the issue to reflect the intended purpose, and that it's adding new capability. |
|
That doesn't tell me how to reproduce it the bug that handling that event fixes. How can I create a test that makes dbm fire that event? |
-- Create dummy mod
local dummyMod = DBM:NewMod("WeakAurasDummyMod")
-- Create initial timer
local timer = dummyMod:NewTimer(60, "Test", "136002")
-- Start time (Fires DBM_TimerStart event with icon 136002)
timer:Start()
-- Update the icon
timer:UpdateIcon("132486")Is the example test mod. In this case, the default state for icon would be The events that should be fired in total are; WeakAura string for testing; |
|
Thanks, I'll take a look at soon. |
Description
DBM timers can call
:UpdateIconwhich will replace the default icon state from when a timer is started. This fires theDBM_TimerUpdateIconevent, and any WeakAuras that have listened to what the icon is should update the icon to reflect these changes.The
DBM_TimerUpdateIconis newly implemented in DeadlyBossMods/DeadlyBossMods@5e75945Type of change
Please delete options that are not relevant.
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist