Skip to content

Conversation

@QartemisT
Copy link
Contributor

@QartemisT QartemisT commented Mar 18, 2024

Description

DBM timers can call :UpdateIcon which will replace the default icon state from when a timer is started. This fires the DBM_TimerUpdateIcon event, and any WeakAuras that have listened to what the icon is should update the icon to reflect these changes.
The DBM_TimerUpdateIcon is newly implemented in DeadlyBossMods/DeadlyBossMods@5e75945

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested DBM icon updating

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@InfusOnWoW
Copy link
Contributor

That still isn't enough, no one is reacting to these events. I would finish the PR, if you tell me how to reproduce the issue easily.

@QartemisT
Copy link
Contributor Author

I've updated the description of the issue to reflect the intended purpose, and that it's adding new capability.

@InfusOnWoW
Copy link
Contributor

That doesn't tell me how to reproduce it the bug that handling that event fixes. How can I create a test that makes dbm fire that event?

@QartemisT
Copy link
Contributor Author

QartemisT commented Mar 18, 2024

-- Create dummy mod
local dummyMod = DBM:NewMod("WeakAurasDummyMod")

-- Create initial timer
local timer = dummyMod:NewTimer(60, "Test", "136002")
-- Start time (Fires DBM_TimerStart event with icon 136002)
timer:Start()

-- Update the icon
timer:UpdateIcon("132486")

Is the example test mod. In this case, the default state for icon would be 136002, and upon updating the icon, it's changed to 132486, however WeakAuras doesn't see that the icon has updated.

The events that should be fired in total are;
DBM_TimerStart - args: Test, Test, 60, 136002, cd
DBM_TimerUpdateIcon - args: Test, 132486


WeakAura string for testing;
!WA:2!DrvZUTTrq4OQwuuEWWwn1ObOhmcq(Pfignoibg9MPIuSlKLuOOtC7fPLChsU1u7YU7sjBFl6sZTcOhbDUN0JGFcie6tGpKha)e0zxs5MeDqCMzNz(MVzMDR1UX4g0g03)WfSqbFGixgc1xrY1jczVmntWvoYl6ffPaDTLeEiAVVGX1bnB11VL3QqHiLkMYhmLLbJUATAlAmKijH2m8cpLMi1obrmotL44IF0oZ0swCmivB8qzL4hC1xKbbekfJsQYG00JOU(GsFTkpaMaC9G8Oi25lh28Gb(dh4FGNVBoMTGSuYfGmBZXGsrIHHImqs0c5cet6JF0dup6hVnh9LaMdVb9B1PJSkGITwMRGHvyMmRsq54zd5AxHsTZXc6o(SXG06BvKJ84eu0XAlmvWbm(fuiaRuFKoYdB1PF7t6mpNxrtNSTmDMjGFPoMw4FUZnyxfKCs6BWEc22(7RZKIyjcs5y5N(H78fZvqAKT)x8viekIohzjKSaPMheBA2)Y2fBScvdiHNflf5C67VBwdnCUEOkHGZMtRMMz3ZA0(xKqoMGouj4Yrwm)2JV)duzB(rzOPivi)1A1Qv)6sRRlk3doXVx23AnI7qcmvSW3YO6e3dq1BkXIDoqTgF3QYfQFRQIUYE(FKR0SOlqckfAKC(Or3U962QydjYlJplSogAlJ64V5vKGRZ2STKD5oVoNqXgdzhF)pH7RrAL12uHK(wjjB2BReklGjmflifgvX5pAPpBRJ62TL3q3E((9o27OxDO)QBHEa7s4Evm60pbhZP2nHEN435OUT(WQ4uX02s4pZbE4f9)YFE39EEj7mhCL5VxAgS48S(mJMj6vb5ATG3BciXD9fgZDaESo57wAKxtT5gLM32AUc3kF1AljwpVT4SzoHfEghxYQBdCqijfQ7AetSg6WWd3YIMl2LazsqcWIt0VZnvqOTd0yaC92EJZt1mhx8Et42f)UJxykrPmsUkSXyeY2eRLdOM5lqb6XKZt(CtmEYcPDp2WyxZBs7LZOlFSQt)3WoC)9jNDZzaKDGbgTNPdLSKXl3AXOCkiJYU76hHmBoVKPi4WKM4EPqmUM3u7I3cTiCs51SVV2Fn((mQxxy6o7TmsI3LhOn7o1ZAGfxZQCH3rr4Gr3uoGBB8ZuJbdA61QvxV)Fzmal6iwSJKXnqajEK0Ses95eoRSkFrX30(kGOmazNGFDXgf7UIwnYhAEeedeZdvnZ4NbOIDDhty82fAR3f5ftkMIFD(CllmXXkF6E26wXi55vt9gQSTE(Up9P7(SNS)tIFgzFiA)Wgt(3t)V

@InfusOnWoW
Copy link
Contributor

Thanks, I'll take a look at soon.

@emptyrivers emptyrivers added the 🎨 Enhancement This pull request implements a new feature. label Mar 30, 2024
@Stanzilla Stanzilla merged commit aba64c9 into WeakAuras:main Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎨 Enhancement This pull request implements a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants