Skip to content

Conversation

@linaori
Copy link
Contributor

@linaori linaori commented Apr 21, 2024

Description

Frame glow currently supports selecting a frame, but managing those values becomes cumbersome real quick. I have a WA that is set to be attached to an action button, and conditionally adds a glow to that action button. I also have a condition to hide the glow but not actually hide the WA. I've noticed that when I want to move my spells to another keybind I find myself having to go through all the tabs and replace the configured frame name, which is a lot of work and easy to make mistakes. It also makes sharing the WA a lot more effort as I have to instruct them what exactly needs to be changed on multiple tabs.

The summary of this change is that it adds a "Parent Frame" option to the "Glow Frame Type" options under "Conditions" , and the "On Show/Hide" options under "Actions".

image

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

I made the same changes in my Addons directory before committing (stable release build) and created a WA that binds to the PlayerFrame and TargetFrame, and will apply and remove the glow when you start moving. I've tested both the Conditions and Actions using this WA though this example only contains the "Conditions" variant

!WA:2!fwv3sTTXx84rtB)hnz6aoT8pKKM6K0qd0omesas)Uwu7cP2GrwajPFiVs7ARniRDZQv2yU0tM2Cn5nWxNR8Jax0RpdtFc4ripbDxjhGjjm9gPJwD2Dp7VpoBUTYh7TWS3z(zVF(25X5Xp)Ah6H83bly8LzHmXdmmmQzm3SlmqY87qeXuw0LY9xrh5XeyIWAuU8XScP7ThsGl4WyHsk)quImGjwNlvZi20ll)arV1B2mMiZnqqAP(JtpoXULGLWhKLrD6EK37GS4Sup)WSVYQNC5Yzyh7JcjgJMrjClcF86pnbjifkNegwy7aQKiq(PB9I2XsKqA61KgrJdmTuVKM9LcARwQZZLNsmk8phGjEjnBQljXkLQuR8MvSK66dLiqZ3pMtcdxfhBEuCIhPdjswxLnD3HUlxSUJBDNI2owjQf3JhI6re2rO2Kyt70u9wHGcLbhp1AcIAQ21RvQsL9tIgvcMdrr(kuRgJQMYYLwZPK9RuHerekCRm0)fdPrnzI2i9PZC)ysyZ00Hp)gumF8AkuiswOPqT5fAfY6k2DeIBJc5biJxLTfL1jOpQE1x2UuP188zrnPTmNpHIh(GTwO5gfNNxP7JhMUs1LcKezmqv(2P8wS5(OiAwrSiKV8beuSolsulzWhatAfXIihIvaNodxnmkIjQ9ah3xNQENHLSAJOrLHfvtawcUp8vWxREFX3CKb65rZeswHmeUSNujaIKty3orj2mTuCJ)eWpyA7hIIJ1rwXkHKoyK6z1ifgyK3FMNpTsTjdPrk91MovwDTs8VatJ1CMdzxPBg26YDL02exCpfls9DLbcsCale37W4aeM19rzO6vphm18oRxJx4SxJSVYXhZpjwYARZytogjjW1ps5syAu0FBkwgyvu9jmUcqnHlU4R00NBk(NcGdRv0wjjkBxSAjbM5Q)DJHPjLP1TcOyc8rMWh)Htbt83ki8A88jXexKxmtKkbRYWKgWvHp5OtgpBSRpy5Jr5(6FQLYnGRyc3e(Sd0dqJBZ6qJA1aUg8Pqbt4)dxcULjFC9U3H4KPH1R2lph)gNnE0MHDv6csd(uNDsHKwi)EUndzmramJN16ooRx1QjlsYhRSGUxHnsqyTQSGJdCVlpbm5Hk1PU5LUDseg(UYW3RfaWpM(Sy6tl9Z(6vr3Ozs(vEhvq0OayPrC9dZ4Ad(yNY7K(yyTuREAmCElPAvGVmhSG2s8MY6V5)wO)olh(OaBnUG538SXmUG4t19imGV9Ytz7hq83zrycJ(DqckYlKyPKWDT7Gctigc)auulIQbi8KfHQWA7NQK0cTd9sKsw06Q(9QncQb0(CvtEIq27aDsQDoTJKT)RVIWaMZu8eL8M2SNvLsLDad9Te6osxAfuCbEwxPBFk4AA49nH7AaZoSEPkLwotwd)VCWDg6Tu3nAxDt8DPBo8uN2BCRO(DvM5TfiE)ThfmmJIo5YHbQ(QeCQD6zxaM2eU9lE(mWpbL0et5EWpRTSWkWQ5Ghaxh(fOYidNY3OiefqCK2g5IcdtDyXbW6nuyWgNYvb2PEiOUY2aoWMV2MaB1q7l02JmVbS9lphGbc8OGrIcnBRi9tjkEJrU4BnYVc)wMah(DTO26Te1zY8)ysWvLDddfc2(EvV9oRUsy1Uva0qhKOfrosKc(kebMbEmS3ZUGY7EIIo7QJa4HnGUWUqhfEdpfeNqLxDBQ6o9e5X05Pw4P1uNMobPMyNZe4zcJEPSIwqcT0IriaOWtmGDow4bHqBTidIaMMWAAKVZ)8W)9

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Contributor

@emptyrivers emptyrivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine, suggestions are nits around de-duplications.

@emptyrivers
Copy link
Contributor

bah, multiline suggestions are hard. some of those line #s are wrong :(

@linaori
Copy link
Contributor Author

linaori commented Apr 21, 2024

The multiline thing broke things indeed 😅 , force-pushed with the changes done manually. I've used the same WA to test OptionsPrivate.Private.glow_frame_types

@emptyrivers emptyrivers merged commit cb1e9d0 into WeakAuras:main Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants