Added "Parent Frame" as option to "Glow Frame Type" #5025
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Frame glow currently supports selecting a frame, but managing those values becomes cumbersome real quick. I have a WA that is set to be attached to an action button, and conditionally adds a glow to that action button. I also have a condition to hide the glow but not actually hide the WA. I've noticed that when I want to move my spells to another keybind I find myself having to go through all the tabs and replace the configured frame name, which is a lot of work and easy to make mistakes. It also makes sharing the WA a lot more effort as I have to instruct them what exactly needs to be changed on multiple tabs.
The summary of this change is that it adds a "Parent Frame" option to the "Glow Frame Type" options under "Conditions" , and the "On Show/Hide" options under "Actions".
Type of change
How Has This Been Tested
I made the same changes in my Addons directory before committing (stable release build) and created a WA that binds to the
PlayerFrameandTargetFrame, and will apply and remove the glow when you start moving. I've tested both the Conditions and Actions using this WA though this example only contains the "Conditions" variantChecklist