ensure we always compute the correct rect for a dynamic group #5034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InfusOnWoW
reviewed
May 2, 2024
Contributor
|
I think that's on the reasonable side as far as hacks is concerned. It's doesn't look that complicated, so yeah I think we should add that. |
This is actually 2 problems in one: - On initial spinup, our PRD anchor doesn't have a valid rect for 1 frame which would be fine, except we're creating it in the same frame we're anchoring dynamic groups to it. Thus, the dynamic group's children also won't have a valid rect. Fix this by forcing an early draw of the PRD anchor via an explicit GetSize call. (see https://warcraft.wiki.gg/wiki/API_ScriptRegion_IsRectValid for more details) - After initial spinup, our PRD anchor is anchored to NamePlate1 (or something that's attached to it, depending on user's addons). Unfortunately for us, Blizzard in their extremely finite wisdom decided to make NamePlate1 a restricted region. Thus, calls to GetRect & friends on any frame in its anchor family will error. This went unnoticed because we explicitly suppress errors on this to avoid user shenanigans breaking WeakAuras. Fix this problem by checking if GetLeft errors: if so, temporarily reanchor the dynamic group to UIParent before computing a new rect for it. Fixes WeakAuras#5023
emptyrivers
force-pushed
the
stupid_prd_problems
branch
from
f5e59ef to
3fc5d0d
Compare
emptyrivers
added
the
🆕 Feature Preview
Contributor
|
An experimental build of WeakAuras with the changes in this pull request is available here. |
emptyrivers
removed
the
🆕 Feature Preview
InfusOnWoW
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually 2 problems in one:
Fixes #5023